Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript definition file #49

Open
alex3165 opened this issue Jan 19, 2017 · 4 comments
Open

Typescript definition file #49

alex3165 opened this issue Jan 19, 2017 · 4 comments

Comments

@alex3165
Copy link

Hey, I really like revalidate, it is very helpful but in my project I am using Typescript so it would be nice to have the appropriated definitions.

If nobody is working on it, I can maybe do something.
@jfairbank
Copy link
Owner

Hi, @alex3165!

I haven't really used Typescript, but I think adding the type definitions would be nice. You're more than welcome to create a PR for that. Thanks!

@alex3165
Copy link
Author

I added a PR to definitely typed, I just converted the types from Flow to Typescript : https://github.com/DefinitelyTyped/DefinitelyTyped/pull/14114/files

@jfairbank
Copy link
Owner

Thanks for doing this @alex3165! Please let me know when your PR is merged, and I'll close this issue.

@ericwooley
Copy link

FYI that was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfairbank @ericwooley @alex3165