From d167331eb84d4e334cf6f35bd2a717f1522303c2 Mon Sep 17 00:00:00 2001
From: Charles Giessen <charles@lunarg.com>
Date: Fri, 15 Mar 2024 16:23:00 -0500
Subject: [PATCH 1/2] vulkaninfo: Add quotes around NULL

Used PrintKeyValue instead of PrintKeyString by mistake.
---
 scripts/vulkaninfo_generator.py     | 2 +-
 vulkaninfo/generated/vulkaninfo.hpp | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/scripts/vulkaninfo_generator.py b/scripts/vulkaninfo_generator.py
index 6da959663..a4b3238ef 100644
--- a/scripts/vulkaninfo_generator.py
+++ b/scripts/vulkaninfo_generator.py
@@ -656,7 +656,7 @@ def PrintStructure(struct, types_to_gen):
                 out += '    }\n'
             else:  # dynamic array length based on other member
                 out += f'    if (obj.{v.arrayLength} == 0) {{\n'
-                out += f'        p.PrintKeyValue("{v.name}", "NULL");\n'
+                out += f'        p.PrintKeyString("{v.name}", "NULL");\n'
                 out += '    } else {\n'
                 out += f'        ArrayWrapper arr(p,"{v.name}", obj.{v.arrayLength});\n'
                 out += f'        for (uint32_t i = 0; i < obj.{v.arrayLength}; i++) {{\n'
diff --git a/vulkaninfo/generated/vulkaninfo.hpp b/vulkaninfo/generated/vulkaninfo.hpp
index c0e93ab14..a856f7dd5 100644
--- a/vulkaninfo/generated/vulkaninfo.hpp
+++ b/vulkaninfo/generated/vulkaninfo.hpp
@@ -1989,7 +1989,7 @@ void DumpVkPhysicalDeviceHostImageCopyPropertiesEXT(Printer &p, std::string name
     p.SetMinKeyWidth(35);
     p.PrintKeyValue("copySrcLayoutCount", obj.copySrcLayoutCount);
     if (obj.copySrcLayoutCount == 0) {
-        p.PrintKeyValue("pCopySrcLayouts", "NULL");
+        p.PrintKeyString("pCopySrcLayouts", "NULL");
     } else {
         ArrayWrapper arr(p,"pCopySrcLayouts", obj.copySrcLayoutCount);
         for (uint32_t i = 0; i < obj.copySrcLayoutCount; i++) {
@@ -2004,7 +2004,7 @@ void DumpVkPhysicalDeviceHostImageCopyPropertiesEXT(Printer &p, std::string name
     }
     p.PrintKeyValue("copyDstLayoutCount", obj.copyDstLayoutCount);
     if (obj.copyDstLayoutCount == 0) {
-        p.PrintKeyValue("pCopyDstLayouts", "NULL");
+        p.PrintKeyString("pCopyDstLayouts", "NULL");
     } else {
         ArrayWrapper arr(p,"pCopyDstLayouts", obj.copyDstLayoutCount);
         for (uint32_t i = 0; i < obj.copyDstLayoutCount; i++) {
@@ -3304,7 +3304,7 @@ void DumpVkSurfacePresentModeCompatibilityEXT(Printer &p, std::string name, cons
     p.SetMinKeyWidth(31);
     p.PrintKeyValue("presentModeCount", obj.presentModeCount);
     if (obj.presentModeCount == 0) {
-        p.PrintKeyValue("pPresentModes", "NULL");
+        p.PrintKeyString("pPresentModes", "NULL");
     } else {
         ArrayWrapper arr(p,"pPresentModes", obj.presentModeCount);
         for (uint32_t i = 0; i < obj.presentModeCount; i++) {

From 136976082d0b14dad8b9687982b2a80cc6e6a633 Mon Sep 17 00:00:00 2001
From: Charles Giessen <charles@lunarg.com>
Date: Sat, 16 Mar 2024 11:14:14 -0500
Subject: [PATCH 2/2] ci: Disable Address Sanitizer in actions runs

Github actions appears to be having a fatal bug that is preventing ASAN workflows from
succeeding. Either the build fails or tests time out, it needs to be disabled for the
time being.
---
 .github/workflows/tools.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/tools.yml b/.github/workflows/tools.yml
index ebc10a563..6baf1f038 100644
--- a/.github/workflows/tools.yml
+++ b/.github/workflows/tools.yml
@@ -84,7 +84,7 @@ jobs:
                 -D BUILD_WERROR=ON \
                 -D INSTALL_ICD=ON \
                 -D BUILD_TESTS=ON \
-                -D ENABLE_ADDRESS_SANITIZER=ON
+                -D ENABLE_ADDRESS_SANITIZER=OFF # Re-enable when github CI doesn't have fatal issues
               env:
                 CC: ${{matrix.cc}}
                 CXX: ${{matrix.cxx}}