links should behave like text, instead of having padding and being centered

[luisrudge]

when I'm adding a link, I expect to be just a regular text. instead, current links behave more like button links (that's why you inherit from the button styles).

[jolbol1]

I have actually encountered this pain point myself. I think I will deviate from the shadcn style here and adjust it. Two possible solutions could be add a link "size" to the button variants removing padding, or simply style the Link in its own way and leave the button as is.

Thanks for the suggestion

[luisrudge]

IMO, I'd go with a separate style for links. Perhaps you can export a LinkButton component that has the button styles (as today), but a standard Link component should behave like any other tag.

[imMatheus]

I think the right thing here is to not have a Link component at all (IMO). If you want the link to be styled as a Button, you import the buttonVariants from button.ts file. That is also what ShadcnUI does, they have not Link component. And especially as all the current Link styling just seems to be a copy paste of styles from Shadcn

So the right thing would be like this

import { buttonVariants } from '@components/button'

const Page = () => {
   return <a className={buttonVariants({variant: 'ghost'})}>A link</a>
}

[jolbol1]

I think the right thing here is to not have a Link component at all (IMO). If you want the link to be styled as a Button, you import the buttonVariants from button.ts file. That is also what ShadcnUI does, they have not Link component. And especially as all the current Link styling just seems to be a copy paste of styles from Shadcn

So the right thing would be like this

import { buttonVariants } from '@components/button'

const Page = () => {
   return <a className={buttonVariants({variant: 'ghost'})}>A link</a>
}

I looked at how I would do this and came to the same conclusion. I don't think there's a good default style for a link. They are too dependent on where you put them and the content around them. Is it in a paragraph, is it in a navbar etc

Will look into making it clearer in the documentation. I still want the Link page as I think its important to let people know that they can use RAC link component and set it up to support NextJS routing, remix etc

[luisrudge]

because tailwindcss resets all link styles, I think a Link component should be provided. Otherwise everyone will have to implement their own style for links, which is something this project is trying to address. If anything, don't add a ButtonLink, but add a TextLink. Just my 2c