-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildpack not working #71
Comments
I am seeing the same thing and the ENV variable suggestion is also not working - and I think that is related to the two open PRs here. |
This started happening today. At the same time the scheduled tests started to fail |
This is happening in our environment too. I can download https://johnvansickle.com/ffmpeg/builds/ffmpeg-git-amd64-static.tar.xz without any issues. I wonder how to resolve this? Can we help? How? |
Same here, started to fail today. Moving the buildpack to the top or bottom of the buildpack list did not help either. Setting FFMPEG_DOWNLOAD_URL is not helping, since it is somehow not picked up by the deployment. |
I filed a ticket at heroku support. Will keep you in loop, if there is a suggestion from them. |
In the meantime i downloaded the binary from https://johnvansickle.com/ffmpeg/builds/ffmpeg-git-amd64-static.tar.xz and added it to my repository. I then deployed the app to Heroku and it is working. Just make sure you call the correct PATH to the binary in your code. |
Did you simply put this file in public directory and then use:
to download it? (In open PR-s I see that this doesn't work for some people) |
I created a bin folder in my repo and placed the binaries in there, both ffmpeg and ffmprobe. You can download both here: https://johnvansickle.com/ffmpeg/builds/ffmpeg-git-amd64-static.tar.xz I then updated my commands like this: command = ["./bin/ffmpeg", "-ss",..... |
Same issue on my end |
👋🏻 |
We need someone with an enterprise account so they can escalate it quickly and not wait for two days for their reply 😭 |
Looked a little deeper into the issue. There seems to be a SSL TLS issue, when the heroku machine curls the tar.xz file, resultung in a status code 000, which is interpreted as error by the buildpack. However, when moving the archive to a different location, the buildpack works flawlessly again. I forked the original buildpack and adjusted the url to a copy of the archive on my servers. Problem solved, deployment is working again. If anyone wants to have a look on my workaround fork in order to build their own: https://github.com/agieche/heroku-buildpack-ffmpeg-latest You can use it for now as drop in replacement of the current non working build pack until things have been sorted out:
Keep in mind, that I will remove the file in a resaonable amount of time after the original url is working again due to a future fix of heroku. |
Thanks @agieche. To clarify, 1) your diagnosis is that johnvansickle.com SSL cert is causing the problem and 2) your fork is only pointing to a different remote URL where an SSL issue is not present, correct? The thing that I am still not seeing function correctly is the |
I tried using the env variable at first, but I could not find an obvious way to access the Heroku env vars from within the shell script. Otherwise, this fork would be unnecessary. I don't think, it is an issue at the end of https://www.johnvansickle.com/ffmpeg/ since curling it from my local machine is working with a correct 200 status code. Seems more of an issue in the local networking of heroku, but I'm not a 100% on this. |
Checked my forked buildpack on two different production apps and deployments went fine. |
Just fixed it for my production app as well. Appreciate the quick hotfix @agieche |
I added support for reading the ENV variables within my fork thanks to this PR: https://github.com/jonathanong/heroku-buildpack-ffmpeg-latest/pull/61/files I set the ENV variable FFMPEG_DOWNLOAD_URL and restarted dynos and the variable was picked up correctly. |
Did you have success setting this variable in the Heroku App ( |
I added the code to my fork. Then set the env variable within web interface (https://dashboard.heroku.com/apps/my-app-16815/settings) and deployed from CLI. Then, the Env variable was picked up correctly. |
Awesome. Thanks! |
I've taken a different approach to resolving this. Instead of using the precompiled binaries from johnvansickle.com, I've moved to using the official Ubuntu apt package. This can be done by:
|
With the Apt buildpack, when I re-deploy then try to run Another alternative buildpack is the heroku-buildpack-activestorage-preview which also installs the ffmpeg binary.
This buildpack also seems to fix the segfault issue on heroku-22 stack (#69) |
Thanks @agieche, I added you as a collaborator. I don't use this build pack anymore. If Heroku wants to own this package, let me know! |
The heroku/heroku-buildpack-activestorage-preview buildpack is officially supported, and has builds of ffmpeg that dynamically link against libraries on the stack images, resulting in much smaller slug sizes. Sort-of addresses jonathanong#71
The heroku/heroku-buildpack-activestorage-preview buildpack is officially supported, and has builds of ffmpeg that dynamically link against libraries on the stack images, resulting in much smaller slug sizes. Sort-of addresses jonathanong#71
Merged #61, so you can set a correct download url via env variable now. No definitive answer from heroku, but they are looking into it. |
@agieche What value should the env variable FFMPEG_DOWNLOAD_URL in heroku client should take? many thanks! |
Just add a new env variable in heroku->setting and redeploy. Before redeploying I also restarted the dynos, but I guess that it is not necessary. This solution is not safe. Do not use it for enterprises and banks. |
@kayvaninvemo is it safe to use this bucket? it looks very suspicious to me |
Its a personal bucket by me. Feel free to upload the archive on your own space and point the env variable to your personal url. This makes it more robust. For the time being, you may use my copy, since Im planning to keep it up until things have been sorted out by heroku support. |
Hey, thanks! In the mean time I tried to use @dzuelke recommendation of using heroku active storage buildpack (#72) I have tested in production and it works. https://github.com/heroku/heroku-buildpack-activestorage-preview.git on heroku buildpacks section |
It is not safe, do not use it if it is for an enterprise or a bank. :D |
Hi! We have had the same problem in our project. Thanks to those who are sharing their valuable solutions! BTW, I did some tests to download the file via
and
|
Any update on this? Is this for Heroku to fix? |
As a quick work around for hosting the ffmpeg-git-amd64-static.tar.xz file, I copied the file into my development public folder, started ngrok and set the Heroku config var |
Got a response by heroku. Seems to be something, that the remote site could fix.
|
This issue is not related to Heroku. The server's TLS handling seems broken (or there is otherwise some other issue with the server) - local requests fail too depending on the client used, for example this is what I get using curl locally on macOS:
Ultimately I think this buildpack is not a great fit for production workloads, since:
I'd recommend that people either:
|
Thanks @edmorley for the very detailed explanation 🙏🏻 |
Looks like it's working again! |
If you are using this in production, I would definitely store the binary in my own file storage. you don't want to rely on third party services like this. When I was using this repo, I was using it at an early stage start up. thanks for the help @agieche, let me know if you can help @edmorley. please email me if any issues come up because I don't code nowadays |
The heroku/heroku-buildpack-activestorage-preview buildpack is officially supported, and has builds of ffmpeg that dynamically link against libraries on the stack images, resulting in much smaller slug sizes. Sort-of addresses #71
Getting this when deploying in heroku:
Using buildpacks:
1. https://github.com/jonathanong/heroku-buildpack-ffmpeg-latest.git
2. heroku/python
-----> ffmpeg app detected
-----> Installing ffmpeg
Variable FFMPEG_DOWNLOAD_URL isn't set, using default value
Downloading https://johnvansickle.com/ffmpeg/builds/ffmpeg-git-amd64-static.tar.xz
Unable to download ffmpeg: 000
The text was updated successfully, but these errors were encountered: