Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daily requirements only generated for first day currently? #148

Open
zanthous opened this issue Apr 24, 2024 · 0 comments
Open

Daily requirements only generated for first day currently? #148

zanthous opened this issue Apr 24, 2024 · 0 comments

Comments

@zanthous
Copy link

zanthous commented Apr 24, 2024

https://github.com/joonspk-research/generative_agents/blob/fe05a71d3e4ed7d10bf68aa4eda6dd995ec070f4/reverie/backend_server/persona/cognitive_modules/plan.py#L489C11-L489C11

In plan.py, line 489 there is

 # - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - TODO
 # We need to create a new daily_req here...
 persona.scratch.daily_req = persona.scratch.daily_req

The first day generates daily_req fine above but for other new days it seems that nothing is created. I haven't run the simulation myself, I'm just reading through the project currently learning how it works and reimplementing in c#. Currently I am at generating an hourly schedule, and it iterates over the daily_req here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant