Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not swallow body on InvalidStatusCode #11

Closed
Palmik opened this issue Jun 30, 2023 · 4 comments · Fixed by #14
Closed

Do not swallow body on InvalidStatusCode #11

Palmik opened this issue Jun 30, 2023 · 4 comments · Fixed by #14

Comments

@Palmik
Copy link

Palmik commented Jun 30, 2023 •
edited
Loading

It would be great to not swallow the response body in case of an InvalidStatusCode, in order to be able to propagate better error messages upstream:

reqwest-eventsource/src/event_source.rs

Line 106 in 181e41e

return Err(Error::InvalidStatusCode(status));

@jpopesculian
Copy link
Owner

hi @Palmik! I can do that! I'll need to make a new major release though, as this would be a breaking change to the API. I'll probably bundle it up with a wasm support update

@Palmik
Copy link
Author

Palmik commented Jul 30, 2023

Thank you!

@Palmik
Copy link
Author

Palmik commented Jul 31, 2023

Here's my temporary solution in the meantime, feel free to use: Palmik@5aa7b41

@phayes
Copy link

phayes commented Sep 25, 2023

I was JUST about to open this ticket. I'm getting an error from a server with an error and I have NO idea what it says! Glad to see it's already being worked on.

@jpopesculian jpopesculian mentioned this issue Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add reqwest::Response to HTTP related errors jpopesculian/reqwest-eventsource
3 participants
@Palmik @phayes @jpopesculian