Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config variables not escaped with latest heroku-api gem #164

Open
fabn opened this issue Feb 26, 2014 · 0 comments
Open

Config variables not escaped with latest heroku-api gem #164

fabn opened this issue Feb 26, 2014 · 0 comments

Comments

@fabn
Copy link

fabn commented Feb 26, 2014

After a bundle update I got heroku-api updated to v0.3.17. After that update I wasn't able to deploy to heroku anymore because some of my heroku vars contains spaces and other special chars.

I don't know this gem enough to diagnose if the issue is related to this gem or to heroku-api. I'll try to understand this, in any case if the issue is not in this gem you should lock the heroku-api gem to version 0.3.15 until the issue is solved, something like

s.add_runtime_dependency "heroku-api", ">= 0.1.2", , "!= 0.3.16", "!= 0.3.17"

By the way I solved the issue by locking heroku-api to version 0.3.15, here are the changes between the two versions. They changed their implementation to multijson, maybe request body is not escaped correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant