Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use regex for DateTime parsing #1

Open
jschpp opened this issue Jul 18, 2020 · 1 comment
Open

Don't use regex for DateTime parsing #1

jschpp opened this issue Jul 18, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jschpp
Copy link
Owner

jschpp commented Jul 18, 2020

At the moment regex is used to parse locale aware datetimes.

Thats not the most robust implementation.
It would be better to split the log line and use DateTime.TryParse()
@jschpp jschpp added the enhancement New feature or request label Jul 18, 2020
@jschpp
Copy link
Owner Author

jschpp commented Jul 19, 2020

Not quite what I planned but this should be better in 61e87e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jschpp