Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project-specific eslint doesn't work #5

Open
evanleck opened this issue Mar 26, 2020 · 6 comments
Open

Project-specific eslint doesn't work #5

evanleck opened this issue Mar 26, 2020 · 6 comments

Comments

@evanleck
Copy link

I don't have eslint installed globally but I do have it installed in the project I'm working on. I see that you use /usr/bin/env eslint which fails when I try it locally and won't pick up the project-specific installation but I believe you can call the project's version at ./node_modules/.bin/eslint from the project root. Maybe this extension could check for a project-specific installation and fall back to a global installation?

I would have created a PR but I'm not familiar with Nova's extension setup, sorry. Let me know if I can help out though or provide more info.

@jsmecham
Copy link
Owner

I'll be making another release (hopefully this evening or tomorrow evening) that will make this possible.

@evanleck
Copy link
Author

That's awesome, thank you!

@jsmecham
Copy link
Owner

Still working on this. Will likely have a release with better support for this tomorrow.

@jwoldan
Copy link

jwoldan commented Apr 8, 2020

It would be really helpful to be able to specify a path to node_modules or eslint directly- for example, in a project I'm working on, node_modules is in a subdirectory within the project.

I'd be willing to help, but it sounds like you already have something related in progress?

@xaphod
Copy link

xaphod commented Sep 17, 2020

Hey i just tried out Nova and i cannot get eslint working with this plugin, i'm assuming this is the same issue as I also keep eslint per-project... any update?

@apexskier
Copy link

#6 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants