Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unevaluatedItems tutorial missing from new site #149

Closed
micshar92 opened this issue Oct 11, 2023 · 6 comments
Closed

unevaluatedItems tutorial missing from new site #149

micshar92 opened this issue Oct 11, 2023 · 6 comments
Labels
good first issue Good for newcomers

Comments

@micshar92
Copy link
Contributor

micshar92 commented Oct 11, 2023

Hey! New website is looking spiffy. I noticed you're sunsetting the old repo, so let me add this tiny issue here.

I wrote the unevaluatedItems tutorial back in June, and while it shows up on the old repo's site, it's still "Documentation Coming Soon" on this new site.

That tutorial is a helpful piece of my portfolio. So if it's all right with you, I want to reformat it (no writing changes) so the style fits this new repo.

@micshar92
Copy link
Contributor Author

Well, shoot. I'm running into the same problem as before with Windows changing line endings on scripts. Which is weird because I'm running yarn on Windows Subsystem for Linux (WSL), not the Windows command line.

Every file has multiple lines of this:

Screenshot 2023-10-11 172121

As far as I can tell, my redesign of the file looks like it'll work, but I can't test it. Sure, I can change the end of line sequence in VS Code, but that saves a different version of every file, so when I upload even just this one Markdown file, it'll be a different type than the one I cloned. Probably not good.

So.... @jdesrosiers you fixed this last time. I need your help on it again. Thanks.

@Relequestual Relequestual added the good first issue Good for newcomers label Oct 12, 2023
@Relequestual
Copy link
Member

Hey @micshar92. It looks like you just need to duplicate the change made in the PR you referenced. This file: https://github.com/jdesrosiers/understanding-json-schema/blob/main/.gitattributes

Happy to accept a PR with that change here if you want to make it.

Additionally, happy if you want to copy over the documentation content in a follow up PR (which it looks was already your plan! woo! Thank you!)

@jdesrosiers
Copy link
Member

@micshar92 Sorry this slipped through the cracks. Thanks for letting us know! And thanks for volunteering to port over the change.

@benjagm
Copy link
Collaborator

benjagm commented Oct 12, 2023

My apologies @micshar92 this was my fault. Thanks for finding it!

@micshar92
Copy link
Contributor Author

PR is done. See #157.

@benjagm
Copy link
Collaborator

benjagm commented Oct 18, 2023

Merged. Huge thanks @micshar92 !

@benjagm benjagm closed this as completed Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants