Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maxDiameter default doesn't adapt on element aspect ratio change #4

Open
juni-vogt opened this issue Oct 12, 2015 · 0 comments
Open
Labels

Comments

@juni-vogt
Copy link
Owner

Since maxDiameter is set depending on the parent's aspect ratio, if the aspect ratio changes while the ripple is still visible, the ripple won't cover the whole element anymore.

This can't be fixed 100% in all cases since element size changes don't trigger an event, the most common way this problem would occur, however, is probably when the window resizes.
So one could add a resize handler to the window and update maxDiameter on resize but that would also require throttling to not make resizing choppy and would blow up the code too much and be a bit overkill.

Possible approach: Add $.ripple.updateDiameter() method that the user can call when needed

@juni-vogt juni-vogt added the bug label Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant