Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre release detection #513

Open
fcollonval opened this issue Jun 19, 2023 · 0 comments
Open

Pre release detection #513

fcollonval opened this issue Jun 19, 2023 · 0 comments

Comments

@fcollonval
Copy link
Member

The test to check a version is a prerelease or not is done using the following Regex:

jupyter_releaser/jupyter_releaser/util.py

Line 353 in 4372a92

match = re.match("([0-9]+.[0-9]+.[0-9]+)", version)

As the package already depends on packaging, should it use it too to check if a version is a pre release (for example to deal with post release)?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fcollonval