Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source tar too large / drastically larger vs before jupyter releaser #592

Open
andrii-i opened this issue Nov 14, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@andrii-i
Copy link

andrii-i commented Nov 14, 2024

Description

Looking for help in understanding why this happened and how to prevent it from happening during the next release.

During the Step 2: Publish Release of Jupyter Scheduler new release 2.10.0 Source Distribution upload failed due to PyPI source distributions size limits (~150 Mb) due to tar build being drastically larger in size vs before jupyter-releaser introduction. Built distribution upload went through, npm upload did not as it's later in the script.

By now 2.10.0 is fixed by building and uploading missing files manually but running jupyter-releaser build-python produces the source of the same size >150 Mb (which causes PyPI size limit errors) vs up to 3 Mb before the jupyter-releaser was introduced. We need to avoid this happening in the the next release.

Reproduce

Expected behavior

Workflow does not fail, source distribution of the reasonable size is built and uploaded to PyPI, upload to npm happens.

Context

@andrii-i andrii-i added the bug Something isn't working label Nov 14, 2024
@andrii-i
Copy link
Author

andrii-i commented Nov 14, 2024

For reference, here is the relevant log excerpt source distribution upload logs:

100% ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 152.0/152.0 MB • 00:03 • 62.2 MB/s
WARNING  Error during upload. Retry with the --verbose option for more details.
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
         File too large. Limit for project 'jupyter-scheduler' is 100 MB. See
         https://pypi.org/help/#file-size-limit for more information.

https://github.com/jupyter-server/jupyter-scheduler/actions/runs/11808986203/job/32898512565#step:5:373

@krassowski
Copy link
Collaborator

Comparing artifacts from

plain hatch jupyter-releaser
image image

@krassowski
Copy link
Collaborator

Good news! New version of pypiserver bundles bottle version which respects file size limits, which means that check-release job will now fail when we attempt to upload too big a file. Bad news: it is not configurable and set to very small number by default so most of our CI now fails, see pypiserver/pypiserver#630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants