Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support plain files #10

Open
jtpio opened this issue Dec 3, 2024 · 3 comments
Open

Support plain files #10

jtpio opened this issue Dec 3, 2024 · 3 comments
Milestone

Comments

@jtpio
Copy link
Member

jtpio commented Dec 3, 2024

Currently ISuggestionsModel expects a NotebookPanel:

https://github.com/QuantStack/jupyterlab-suggestions/blob/26b00123d50a846cf200c9c49488bd1c2279a79d/packages/base/src/types.ts#L28-L31

Since suggestions are currently displayed in the right sidebar, it could be interesting to also consider supporting suggestions for plain files, such as Python or Markdown files.

Although this may add some challenges as to where the suggestions should be saved, as there would be no notebook metadata for such files: #1

@trungleduc
Copy link
Member

yeah, i will get back to the plain files later after the integration with the jupyter-collaboration backend

@trungleduc
Copy link
Member

we probably need to handle the plain files differently

@jtpio
Copy link
Member Author

jtpio commented Dec 3, 2024

Sounds good 👍

Also it's fine to completely break and change interfaces as needed now since we are still in the early iterations.

@trungleduc trungleduc added this to the 0.2.0 milestone Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants