Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX in advocates table sort filter does not toggle properly #360

Open
0xlyd opened this issue Jul 29, 2020 · 1 comment
Open

FIX in advocates table sort filter does not toggle properly #360

0xlyd opened this issue Jul 29, 2020 · 1 comment
Labels
check Control if the behaviour is as per requirements frontend Bugs related to the frontend

Comments

@0xlyd
Copy link
Contributor

0xlyd commented Jul 29, 2020

Expected Behavior

When I toggle the sort filter to do ASC/DESC instead there is another state where the sorting icon is not rendered. Once I click it should toggle

Current Behavior

After I click on the sorting filter, then I click again (it reverses the order correctly) and with another click the icon disappears

Possible Solution

Once I click on sort it should then toggle between ASC/DESC sorting

Steps to Reproduce

Environment: Temp

  1. Go to My Advocacy page
  2. Click on Total Earned for three times

Detailed Description

Video: https://drive.google.com/file/d/15R20WORp9forvOxni0WivEEjxyl_reM9/view

@0xlyd 0xlyd added the frontend Bugs related to the frontend label Jul 29, 2020
@0xlyd 0xlyd added this to the Advocate + Reward milestone Jul 29, 2020
@ashishjur
Copy link

ashishjur commented Jul 30, 2020

I think this is intended. All sorts have three states

  1. Asc
  2. Desc
  3. Default (could also be unsorted)

The icon doesn't show up in the case of the default sort.

cc @lucaydaniel

@ashishjur ashishjur added the check Control if the behaviour is as per requirements label Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check Control if the behaviour is as per requirements frontend Bugs related to the frontend
Projects
None yet
Development

No branches or pull requests

3 participants