Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dynamic_routing): remove dynamic_routing from realease features #6896

Closed
wants to merge 1 commit into from
Closed

fix(dynamic_routing): remove dynamic_routing from realease features #6896

wants to merge 1 commit into from

Conversation

prajjwalkumar17
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

removed dynamic_routing from release faeture set

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 added this to the December 2024 Release milestone Dec 19, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Dec 19, 2024
@prajjwalkumar17 prajjwalkumar17 requested a review from a team as a code owner December 19, 2024 10:52
@semanticdiff-com SemanticDiff.com
Copy link

Review changes with  SemanticDiff

@prajjwalkumar17 prajjwalkumar17 linked an issue Dec 19, 2024 that may be closed by this pull request
fix(dynamic_routing): remove dynamic_routing from realease features #6897
Open
@prajjwalkumar17
Copy link
Contributor Author

We had a runtime fature flag in-place so didn't need to switch off compile time flag.
Hence closing this.

@SanchithHegde SanchithHegde deleted the disable_dynamic_routing branch December 23, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SanchithHegde SanchithHegde SanchithHegde approved these changes

Assignees

@prajjwalkumar17 prajjwalkumar17

Labels
Hotfix
Projects
None yet
Milestone
December 2024 Release
Development

Successfully merging this pull request may close these issues.

fix(dynamic_routing): remove dynamic_routing from realease features
2 participants
@prajjwalkumar17 @SanchithHegde