Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Search #105

Open
3 of 6 tasks
justinpombrio opened this issue Jun 9, 2024 · 1 comment
Open
3 of 6 tasks

Implement Search #105

justinpombrio opened this issue Jun 9, 2024 · 1 comment
Labels

Comments

@justinpombrio
Copy link
Owner

justinpombrio commented Jun 9, 2024

Four levels of search:

  • General. Search highlighting. A Search is a predicate on nodes. Highlight any node that matches the predicate. n/N jumps to the next/prev node that matches the predicate (via next/prev_inorder). There's a shortcut to clear the search.
  • General. Make overlapping search & cursor highlighting not awful.
  • 1. Jump to next/prev node of given type
  • 2. Find exact matches of the current node (like * in Vim). Should highlight and count the matches, ideally being lazy if there are a lot.
  • 3. Substring search, over all texty nodes.
  • 4. Tree search with "." for any single node and ".*" for zero or more nodes in a listy context.

MVP is at least (1), probably (1-3).

@e-matteson
Copy link
Collaborator

1 is done in 7fb5e37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants