feat: change poweroff to take effect 5 seconds after requested #3126
Labels
enhancement
New feature or request
triage
Add this label to issues that should be triaged and prioretized in the next planning call
Comments
mauromorales
added
enhancement
mauromorales
added a commit
to kairos-io/kairos-sdk
that referenced
this issue
Jan 14, 2025
see kairos-io/kairos#3126 Signed-off-by: Mauro Morales <[email protected]>
mauromorales
added a commit
to wrkode/kairos-sdk
that referenced
this issue
Jan 14, 2025
see kairos-io/kairos#3126 Signed-off-by: Mauro Morales <[email protected]>
mauromorales
added a commit
to kairos-io/kairos-sdk
that referenced
this issue
Jan 14, 2025
* adding utils components to handle k0s Signed-off-by: William Rizzo <[email protected]> * Adding systemd units for k0s Signed-off-by: William Rizzo <[email protected]> * fix k0s services Signed-off-by: William Rizzo <[email protected]> * Remove shutdown now, it will be addressed later see kairos-io/kairos#3126 Signed-off-by: Mauro Morales <[email protected]> * Revert FindCommand changes This function is not specific for k3s hence also not for k0s Signed-off-by: Mauro Morales <[email protected]> * Remove utils.Version() For versioning we now use the versioneer package also in this repo. I couldn't find any instance of components depending on utils.Version() so I think it's safe to remove Signed-off-by: Mauro Morales <[email protected]> * Revert changes to the go.mod & go.sum files Signed-off-by: Mauro Morales <[email protected]> * Revert "Remove utils.Version()" This reverts commit c5f48d9. * Remove utils.Version() This is not being used anymore, use Versioneer package instead Signed-off-by: Mauro Morales <[email protected]> * Update machine/machine.go Co-authored-by: Dimitris Karakasilis <[email protected]> --------- Signed-off-by: William Rizzo <[email protected]> Signed-off-by: Mauro Morales <[email protected]> Co-authored-by: Mauro Morales <[email protected]> Co-authored-by: Dimitris Karakasilis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current functionality of poweroff waits 5 seconds from the kairos side and then 1 min from the shutdown command to go into effect. The idea is to give enough room to the interactive user to cancel the request, but having to wait 1min and 5sec for the non interactive user is a bit too long.
Let's change this to give a message leeting the user know they have 5 seconds to cancel
https://github.com/kairos-io/kairos-agent/blob/347a30b261d055b4876dd298816a9d503cdbb926/internal/agent/hooks/lifecycle.go#L20-L21
And then change
shutdownto doshutdown nowhttps://github.com/kairos-io/kairos-sdk/blob/a2d305dd6d7fcda8378151c02b9335944cc5e953/utils/utils.go#L261
The text was updated successfully, but these errors were encountered: