You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since test suites bump unfolding threshold to 150, I find they don't reflect the environment people write code in.
As an example, when I run into the problem from #112 while fiddling with test suite of optics and wanted to include this in the test suite of generic-optics, it turned out that everything inlines just fine within Spec.hs module because of increased unfolding threshold.
If increased threshold is absolutely needed for comparison of the definition of lenses, I suggest going another route: don't compare definitions, compare usage sites of definitions (i.e. don't test core of lenses themselves, test core of applying them to view/set/over etc.
Since test suites bump unfolding threshold to 150, I find they don't reflect the environment people write code in.
As an example, when I run into the problem from #112 while fiddling with test suite of
optics
and wanted to include this in the test suite ofgeneric-optics
, it turned out that everything inlines just fine withinSpec.hs
module because of increased unfolding threshold.If increased threshold is absolutely needed for comparison of the definition of lenses, I suggest going another route: don't compare definitions, compare usage sites of definitions (i.e. don't test core of lenses themselves, test core of applying them to
view
/set
/over
etc.optics
has https://github.com/well-typed/optics/blob/0dea927/optics/tests/Optics/Tests/Labels.hs and when I replaced TH optics with generic optics everything passes with #112 and default compiler options, so I consider it a reasonable approach.The text was updated successfully, but these errors were encountered: