Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain TypeScript types? #291

Open
mAAdhaTTah opened this issue Jan 22, 2019 · 4 comments
Open

Maintain TypeScript types? #291

mAAdhaTTah opened this issue Jan 22, 2019 · 4 comments

Comments

@mAAdhaTTah
Copy link
Collaborator

We maintain types for Flow, but there are TS types in DefinitelyTyped. I have an open PR to update them, but I'm wondering if maybe it makes more sense to pull them in and maintain them ourselves? It would be easier to then keep the Flow & TS types in sync.

@Macil
Copy link
Collaborator

Macil commented Jan 22, 2019

I'm in favor of pulling them in.

We can make our tests sanity check the definitions by adding a tsconfig.json that includes "noEmit": true, adding typescript to devDependencies, and adding && tsc to package.json's scripts.test.

@gamb
Copy link

gamb commented Oct 1, 2020

Any change of decision here or still thinking you'll pull the types in? Happy to help if I can

@mAAdhaTTah
Copy link
Collaborator Author

@gamb I'm still open to it but I haven't had to make changes since the PR I opened in the OP so it hasn't been a high priority. If you want to PR in the types & handle deprecating them in the DT repo, I'd approve it.

@gamb
Copy link

gamb commented Oct 1, 2020

@mAAdhaTTah Thanks. I'll try to find some time to put something up 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants