-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintain TypeScript types? #291
Comments
I'm in favor of pulling them in. We can make our tests sanity check the definitions by adding a tsconfig.json that includes |
Any change of decision here or still thinking you'll pull the types in? Happy to help if I can |
@gamb I'm still open to it but I haven't had to make changes since the PR I opened in the OP so it hasn't been a high priority. If you want to PR in the types & handle deprecating them in the DT repo, I'd approve it. |
@mAAdhaTTah Thanks. I'll try to find some time to put something up 👍 |
We maintain types for Flow, but there are TS types in DefinitelyTyped. I have an open PR to update them, but I'm wondering if maybe it makes more sense to pull them in and maintain them ourselves? It would be easier to then keep the Flow & TS types in sync.
The text was updated successfully, but these errors were encountered: