Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container reconfiguration is broken #930

Open
wkz opened this issue Feb 5, 2025 · 3 comments
Open

Container reconfiguration is broken #930

wkz opened this issue Feb 5, 2025 · 3 comments
Assignees
Labels
bug Something isn't working cn:styx
Milestone

Comments

@wkz
Copy link
Contributor

wkz commented Feb 5, 2025

Current Behavior

After a container has been launched any further reconfiguration is not applied until after reboot or a manual container {stop, setup, start} cycle.

Expected Behavior

  1. Setup docker://nginx:alpine
  2. Activate

As expected, the default landing page is accessible

  1. Add a content mount with a custom landing page
  2. Activate

The custom landing page is expected to be seen, but the default is still shown

Steps To Reproduce

No response

Additional information

The root cause is that the download/setup phase for the container is run by finit as a task. So unless the runlevel changes (which it does not during a normal reconfig-cycle), the setup phase is not run again.

@wkz wkz added bug Something isn't working triage Pending investigation & classification (CCB) labels Feb 5, 2025
@troglobit troglobit self-assigned this Feb 7, 2025
@troglobit troglobit removed the triage Pending investigation & classification (CCB) label Feb 7, 2025
@troglobit troglobit moved this to In progress in Infix & C:o Feb 7, 2025
@troglobit
Copy link
Contributor

@jovatn
Copy link
Contributor

jovatn commented Feb 10, 2025

@troglobit Milestone 25.02? I will assume this was the intention during last CCB, and add it to 25.02 now.

@jovatn jovatn added this to the Infix v25.02 milestone Feb 10, 2025
@troglobit
Copy link
Contributor

@troglobit Milestone 25.02? I will assume this was the intention during last CCB, and add it to 25.02 now.

Indeed, thanks for keeping track 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cn:styx
Projects
Status: In progress
Development

No branches or pull requests

3 participants