Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-privileged users do not have access to sysrepocfg #932

Open
wkz opened this issue Feb 7, 2025 · 1 comment
Open

Non-privileged users do not have access to sysrepocfg #932

wkz opened this issue Feb 7, 2025 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@wkz
Copy link
Contributor

wkz commented Feb 7, 2025

Current Behavior

When granting a non-privileged user shell access via clish, many admin/exec commands are broken.

Using {NET,REST}CONF though, the user is able to access the expected data.

Expected Behavior

clish should have access to the same data set that is available to the user via {NET,REST}CONF.

Steps To Reproduce

  1. Create a non-privileged user, "guest", with clish as their shell
  2. Login as "guest"
  3. Run show interfaces or show software, for example

Additional information

The root cause seems to be that the user can not extract any data via sysrepocfg, which clish uses for most of its admin/exec commands.

@wkz wkz added bug Something isn't working triage Pending investigation & classification (CCB) labels Feb 7, 2025
@troglobit
Copy link
Contributor

CCB: a guest user should be able to access sysrepo, but be blocked access by the NACM layer (in sysrepo) from what they can access.

Add new UNIX group, e.g. sysrepo-users, which the /dev/shm/*sysrepo* files are read-write group member of. This way even a guest user will be member of, meaning they will be able to connect to sysrepo to query status -- filtered via NACM rules.

We also need to add admin users to the frrvtysh group (like we already do for the wheel (root) group).

@troglobit troglobit removed the triage Pending investigation & classification (CCB) label Feb 7, 2025
@troglobit troglobit added this to the Infix v25.03 milestone Feb 7, 2025
@troglobit troglobit moved this to Todo in Infix & C:o Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants