From b70728f4736b3a0c4d8ca0df5e8bbe4ab6f827e2 Mon Sep 17 00:00:00 2001 From: Matthias Ronge Date: Wed, 19 Apr 2023 14:16:28 +0200 Subject: [PATCH] Remove unneccessary null-checks MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It seems that 'settings' can never be null, as other parts of the code rely on it not being null, without checking for it. The commit doesn’t touch public boolean isRequired() as it is handled in a different PR already. --- .../production/forms/createprocess/ProcessSimpleMetadata.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessSimpleMetadata.java b/Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessSimpleMetadata.java index 063b613c420..6924b42eead 100644 --- a/Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessSimpleMetadata.java +++ b/Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessSimpleMetadata.java @@ -77,12 +77,12 @@ protected BiConsumer, String> getStructureFieldSetters(MetadataViewI * @return whether the field is editable */ public boolean isEditable() { - return Objects.isNull(settings) || settings.isEditable(); + return settings.isEditable(); } @Override public boolean isUndefined() { - return Objects.isNull(settings) || settings.isUndefined(); + return settings.isUndefined(); } public boolean isRequired() {