Allow for Syntect to simply generate CSS classes #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run on Sun Nov 12 03:18:37 UTC 2023 |
gjtorikian
force-pushed
the
use-css-if-you-like
branch
2 times, most recently
from
2295792 to
b33e337
Compare
kivikakk
force-pushed
the
use-css-if-you-like
branch
from
b33e337 to
4b9d838
Compare
|
Thank you so much! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntect has the ability to generate its syntax highlighting with CSS classes, rather than inline styles.
I wanted to use this in Commonmarker, but I couldn't find an easy, non-breaking API to support this feature. I'm happy to rework or rearchitect it into anything that looks better. Technically this is still a non-1.0 library so breaking changes are permitted per sem ver, but, well, you know.... people.