Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ACM Certificates #54

Open
bugeats opened this issue Aug 29, 2018 · 3 comments
Open

Support ACM Certificates #54

bugeats opened this issue Aug 29, 2018 · 3 comments

Comments

@bugeats
Copy link

bugeats commented Aug 29, 2018

Right now s3-website assumes that your certificates have been manually imported in to IAM, when many users will have their certificates provisioned natively by ACM.

@nick-benoit14
Copy link
Collaborator

nick-benoit14 commented Aug 30, 2018

Howdy,

Thanks for reaching out! I am not very familiar with this issue. I will do some reading to try and educate myself. Do you have any propositions for how it would work in an ideal world?

@bugeats
Copy link
Author

bugeats commented Aug 30, 2018

Hey there. Yeah I was a bit surprised to see that the cert stuff didn't default to using AWS Certificate Manager. I thought it was the more common way to use the AWS stack. It's simple stuff. Just another AWS service to create and manage SSL certs for you.

I figure the cleanest possible solution is to just add a new configuration key.

{
  // use a legacy IAM cert
  certId: 'ABC-123'
}

and now

{
  // use an ACM provisioned cert
  acmCertId: `XYZ-456`
}

That would be backwards compatible.

Now if you wanted to get real fancy, you could have s3-website actually create or discover a new cert from you based on the domain name. Something like:

{
  // create a new cert
  domain: 'myapp.example.com',
  createAcmCert: true
}

@nick-benoit14
Copy link
Collaborator

@bugeats Sorry, school has been starting up this week. This is on my roadmap for this project, but if it is something that is impacting you personally and is time sensitive, I will happily accept a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants