Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate team attribute to make sure it's an ID, not a name #19

Open
technicalpickles opened this issue Sep 25, 2015 · 0 comments
Open

Comments

@technicalpickles
Copy link

I ran into this while getting started. Given the example:

Rails.application.config.middleware.use OmniAuth::Builder do
  provider :slack, "API_KEY", "API_SECRET", scope: "identify,read,post", team: 'XXXXXXXX'
end

XXXXXXXX needs to be a team ID, like TXXXX, rather than a Team domain name, like my-awesome-team. It should be possible to check this with regex at startup time.

I left feedback with Slack to implement at the server level, so they raise an error if you pass an invalid Team ID (like when using a team domain instead).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant