Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RequestReply: Configure Timeout Default in Feature Configmap #8338

Closed
2 tasks
Cali0707 opened this issue Nov 21, 2024 · 2 comments · Fixed by #8361
Closed
2 tasks

RequestReply: Configure Timeout Default in Feature Configmap #8338

Cali0707 opened this issue Nov 21, 2024 · 2 comments · Fixed by #8361
Assignees
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)

Comments

@Cali0707
Copy link
Member

Problem
Currently, the default timeout for each RequestReply resource is hardcoded to 30 seconds:

if rrs.Timeout == nil || *rrs.Timeout == "" {
rrs.Timeout = ptr.To("30s")
}

This should instead be a configurable global value, with key requestreply-default-timeout, similar to the change made in #7996.

Persona:
Which persona is this feature for? System administrators

Exit Criteria

  • The feature flag is added
  • The request reply defaulting logic checks the feature flag

Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1

Additional context (optional)
Add any other context about the feature request here.

@Cali0707
Copy link
Member Author

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Nov 21, 2024
@AlexMamoukarys
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature-request triage/accepted Issues which should be fixed (post-triage)
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants