From d9f06bb3017b1eb0b390830dcc7f063f256fb741 Mon Sep 17 00:00:00 2001 From: Hans Knecht Date: Mon, 10 Apr 2023 11:07:49 -0400 Subject: [PATCH] fix: extraENVs should be an array not object --- charts/ecr-cleanup/Chart.yaml | 4 ++-- charts/ecr-cleanup/README.md | 4 ++-- charts/ecr-cleanup/values.schema.json | 2 +- charts/ecr-cleanup/values.yaml | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/charts/ecr-cleanup/Chart.yaml b/charts/ecr-cleanup/Chart.yaml index c0c573e..1fbb608 100644 --- a/charts/ecr-cleanup/Chart.yaml +++ b/charts/ecr-cleanup/Chart.yaml @@ -20,10 +20,10 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.3.0 +version: 0.3.1 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to # follow Semantic Versioning. They should reflect the version the application is using. # It is recommended to use it with quotes. -appVersion: "0.3.0" +appVersion: "0.3.1" diff --git a/charts/ecr-cleanup/README.md b/charts/ecr-cleanup/README.md index 33f6f9d..3e93f1d 100644 --- a/charts/ecr-cleanup/README.md +++ b/charts/ecr-cleanup/README.md @@ -6,7 +6,7 @@ Deploys a job that cleans up an ECR repo based on the following rules. 3. Has the container been tagged with the word `keep` 4. Is the container the only tag in the ECR repository -![Version: 0.3.0](https://img.shields.io/badge/Version-0.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.3.0](https://img.shields.io/badge/AppVersion-0.3.0-informational?style=flat-square) +![Version: 0.3.1](https://img.shields.io/badge/Version-0.3.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.3.1](https://img.shields.io/badge/AppVersion-0.3.1-informational?style=flat-square) ## Values @@ -15,7 +15,7 @@ Deploys a job that cleans up an ECR repo based on the following rules. | awsRegistryId | string | `""` | ECR Registry ID to override picking the default | | command | list | `["/code/main.py"]` | Command being run by the cronjob | | dryRun | bool | `false` | Should the tool run in dryrun | -| extraEnvs | object | `{}` | | +| extraEnvs | list | `[]` | | | fullnameOverride | string | `""` | Override fullname | | image.pullPolicy | string | `"IfNotPresent"` | Pull Policy for images in cronjob | | image.registry | string | `"ghcr.io"` | Image Registry | diff --git a/charts/ecr-cleanup/values.schema.json b/charts/ecr-cleanup/values.schema.json index bc6e61b..a6a9f8c 100644 --- a/charts/ecr-cleanup/values.schema.json +++ b/charts/ecr-cleanup/values.schema.json @@ -16,7 +16,7 @@ }, "extraEnvs": { "type": [ - "object", + "array", "null" ] }, diff --git a/charts/ecr-cleanup/values.yaml b/charts/ecr-cleanup/values.yaml index c0d9ee1..cf2a3c0 100644 --- a/charts/ecr-cleanup/values.yaml +++ b/charts/ecr-cleanup/values.yaml @@ -75,4 +75,4 @@ resources: # memory: 128Mi ## -- ENV variables to pass to cronjob -extraEnvs: {} +extraEnvs: []