Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use $.xml() to output markup when parserOptions.xmlMode is true #4

Closed
jessehattabaugh opened this issue Jul 2, 2014 · 1 comment
Closed

Comments

@jessehattabaugh
Copy link

I am using gulp-cheerio to edit a PhoneGap config.xml file at build time. Self-closing elements such as

<icon src="icon.png"/>

get transformed into

<icon src="icon.png"></icon>

This is because gulp-cheerio outputs to the file using $.html() (index.js line 25) instead of $.xml() which keeps the self-closing tags.

A similar bug was filed against this grunt plugin cgross/grunt-dom-munger#4

@knpwrs
Copy link
Owner

knpwrs commented Dec 30, 2014

I believe this was fixed but never closed: https://github.com/KenPowers/gulp-cheerio/blob/master/lib/index.js#L25

@knpwrs knpwrs closed this as completed Dec 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants