Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace "-" with "-" in snapshot names #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace "-" with "-" in snapshot names #21

wants to merge 1 commit into from

Conversation

amulet1
Copy link
Collaborator

@amulet1 amulet1 commented Jan 21, 2025

Partially (?) resolves #20.

@amulet1
Replace "-" with "-" in snapshot names
ab934ce 
Partially resolves amulet1/pve-purestorage-plugin #8.
@amulet1 amulet1 requested a review from timansky as a code owner January 21, 2025 18:05
@timansky
Copy link
Collaborator

timansky commented Jan 21, 2025 •
edited
Loading

logic seems to lead to conflict.
For example if i create snapname with - and then will try to create with _ (or otherwise)

at least info message need to be added, that indicates _/- replacement

@timansky
Copy link
Collaborator

I do not have veam to test but may be it is need to clarify that prefix snap-veeam_d04ef44c108e08e86b2bb0f71f is static
if it is static for veam maybe this logic needs only veeam snapshot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timansky timansky Awaiting requested review from timansky timansky is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Veeam snapshots are not working
2 participants
@amulet1 @timansky