Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Napari GUI: Parameter/config checking happens at widget runtime #209

Open
qin-yu opened this issue Mar 6, 2024 · 2 comments
Open

Napari GUI: Parameter/config checking happens at widget runtime #209

qin-yu opened this issue Mar 6, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request GUI Napari GUI related

Comments

@qin-yu
Copy link
Collaborator

qin-yu commented Mar 6, 2024

Input should be checked and stopped at Napari interface before widget buttons get clicked.

@qin-yu qin-yu self-assigned this Mar 6, 2024
@qin-yu qin-yu added the enhancement New feature or request label Mar 6, 2024
@qin-yu
Copy link
Collaborator Author

qin-yu commented Mar 20, 2024

What I meant was that widgets fails to run because input could be invalid. Now I want to make the checking while user is inputting.

@qin-yu
Copy link
Collaborator Author

qin-yu commented Apr 15, 2024

This Issue refers to the parameters/configs put into the Napari GUI.

Actually some inputs are checked like

https://github.com/hci-unihd/plant-seg/blob/7acc49c0d5ecc0414898f11e179b83fc3a6367b2/plantseg/viewer/widget/io.py#L194

I also added some:

https://github.com/hci-unihd/plant-seg/blob/7acc49c0d5ecc0414898f11e179b83fc3a6367b2/plantseg/viewer/widget/predictions.py#L205

But configs/args put into functions still need to be checked by Pydantic.

@qin-yu qin-yu added the GUI Napari GUI related label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI Napari GUI related
Projects
None yet
Development

No branches or pull requests

1 participant