Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need documentation #26

Open
karanaggarwal1 opened this issue Mar 13, 2018 · 3 comments
Open

Need documentation #26

karanaggarwal1 opened this issue Mar 13, 2018 · 3 comments

Comments

@karanaggarwal1
Copy link

There should be documentation for explaining the server side code, as well as the folder structure. Even though it is inherited from create-react-app, some kind of documentation should be present.
Steps to Reproduce
NA
I would like to work on this.

@koistya
Copy link
Member

koistya commented Mar 15, 2018

Thanks, a PR would be highly appreciated. You can take a look here as an example project.

@karanaggarwal1
Copy link
Author

Okay sure. I would look into it

@PabloMarch
Copy link

PabloMarch commented May 23, 2018

Missing const assets = require('./assets.json'); on the app.node.js, this should be also explained on the documentation.

EDITED:

In case anyone else is having this same question this is the content of my file build/assets.json:

{
  "main": [
    "static/js/bundle.js",
    "static/js/bundle.js.map"
  ]
}

and update the require to const assets = require('./assets.json').main;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants