Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Support Safari 13 #38

Closed
brainsik opened this issue Aug 24, 2019 · 32 comments
Closed

Support Safari 13 #38

brainsik opened this issue Aug 24, 2019 · 32 comments

Comments

@brainsik
Copy link

brainsik commented Aug 24, 2019

Safari Technology Preview has native support for U2F. It would be great if the Krypton extension could work with this version. Going to the extensions gallery page doesn't show an "install" button.

@apburgess
Copy link

apburgess commented Sep 5, 2019

+1 -- Especially as the upcoming version of Safari in macOS Catalina and the next version of Safari for Mojave won't support the old Safari extension system either.

@agrinman
Copy link
Contributor

agrinman commented Oct 9, 2019

We're working on a new macOS app that brings support to safari 13 (and any other browser, without a browser extension). If you're interested in access to the beta, signup is here: https://forms.gle/4keW9m86sFadxtEi6

@agrinman agrinman changed the title Support Safari Technology Preview Support Safari 13 Oct 9, 2019
@vzhilov
Copy link

vzhilov commented Oct 9, 2019

Is this going to be for Safari 13 on iPadOS as well?

@dspaxton
Copy link

dspaxton commented Feb 6, 2020

whats the status of this issue? i signed up for the beta when i saw the link but it appears nothing is happening

@ryoppippi
Copy link

Me neither
Please respond to our signup

@drcongo
Copy link

drcongo commented Feb 28, 2020

I'm starting to worry that the Kryptonite team have all been locked in a cupboard at Akamai

@dspaxton
Copy link

I'm starting to worry that the Kryptonite team have all been locked in a cupboard at Akamai

the lack of activity here would seem to confirm that supposition

@drcongo
Copy link

drcongo commented Mar 4, 2020

Such a shame, I love Kryptonite.

@agrinman
Copy link
Contributor

agrinman commented May 8, 2020

Sorry for the delay here! Our macOS app needs access to the new DriverKit entitlement from apple as we'll need to utilize a user-space kernel extension (for universal browser support).

HOWEVER! We decided to just release Safari-app extension macOS app for Krypton so while we get the above working, Krypton users will still be able to have solid Safari support.

It's currently in review in the mac app store, so please stay tuned in the next couple of days we'll be able to push this out.

@agrinman
Copy link
Contributor

agrinman commented May 8, 2020

Another update: will release on the app store soon.
In the mean time, here's a signed build you can download and use now: Download Krypton for Mac

@lumaxis
Copy link

lumaxis commented May 9, 2020

@agrinman Fantastic to see you active again here 🙂

@agrinman
Copy link
Contributor

agrinman commented May 10, 2020

On the App Store!
https://apps.apple.com/us/app/krypton-authenticator-desktop/id1512484779?ls=1

@agrinman
Copy link
Contributor

Please test it out and let me know if there are any issues :)

@jackdorland
Copy link

Thank you so much! I've been waiting for this for ages :)

@jackdorland
Copy link

jackdorland commented May 11, 2020

Hmm.
Seems Google doesn't want to play nice. Any insights?

https://imgur.com/afJCiDV
Otherwise, really good work on the new extension. I never knew how much I missed the zero-touch logins until now.

EDIT: Seems GitHub is having a moment with my Imgur link; Here's the link without markdown: https://imgur.com/afJCiDV

@jackdorland
Copy link

Also seems to have created a ghost GitHub in my Krypton app. Odd.

image

@agrinman
Copy link
Contributor

@pugthelouie can you create a separate issue for these?

@jackdorland
Copy link

Sure! Hold on.

@jackdorland
Copy link

I presume the iOS app's duplicate entry bug should go in kryptco/krypton-ios

@agrinman
Copy link
Contributor

Yeah -- this is because GitHub upgraded from U2F to WebAuthn, hence Krypton iOS treats that as a different appid -- well, because it is, and doesn't know (yet) to map them to the same service. Easy fix, but will come a bit later as it's just cosmetic.

@jackdorland
Copy link

Alright. I opened the issue for future reference- There's the other Google one in this repo at #45

@jackdorland
Copy link

Oh and- Will this new app be open sourced?

@agrinman
Copy link
Contributor

Public sourced soon, TBD on "open"

@drcongo
Copy link

drcongo commented May 11, 2020

Installed from the Mac App Store, I get this...

Screen Shot 2020-05-11 08 58 28 AM

And there's no sign of a Krypt Safari extension in my Safari's extensions, have I messed this up?

@agrinman
Copy link
Contributor

@drcongo looks like a few users are getting this..very strange. Can you quite safari and restart it?

@agrinman
Copy link
Contributor

@drcongo are you on 10.15 or and older macOS?

@drcongo
Copy link

drcongo commented May 11, 2020

Hey @agrinman, I've tried that a few times. Let me know if there's log files or anything I can send over to help you debug it.

I'm on 10.14.6 (with no plans on upgrading to Catalina)
Safari version 13.1 (14609.1.20.111.8)

@agrinman
Copy link
Contributor

Yep looks like this is a 10.14.6 issue. Will try to push a fix soon, I can post a pre-release build here so it would be great if you could test it out on your system.

@drcongo
Copy link

drcongo commented May 11, 2020

Happy to help @agrinman, I've missed having Kryptonite in Safari.

@agrinman
Copy link
Contributor

@drcongo Just released v1.1 on the macOS App Store that should fix this problem

@drcongo
Copy link

drcongo commented May 12, 2020

@agrinman Confirmed working here, nice work sir!

@agrinman
Copy link
Contributor

Closing now that Krypton's new Safari macOS app extension is live and seems to work for folks.

Please open any issues with Safari as new github issues. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants