Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiline strings #139

Closed
maguro opened this issue Apr 23, 2019 · 3 comments
Closed

Add support for multiline strings #139

maguro opened this issue Apr 23, 2019 · 3 comments

Comments

@maguro
Copy link

maguro commented Apr 23, 2019

I am shepherding a change in Protobufs to allow multi-line string values:

protocolbuffers/protobuf#1297
protostuff/protostuff-compiler#60

This ticket serves as a marker for the corresponding effort required in this project. I have forked this project and gotten a working version on my fork. I'll submit a PR once things start solidifying in the protobuf project.

@maguro
Copy link
Author

maguro commented Apr 23, 2019

Looking good...

Screen Shot 2019-04-23 at 1 03 49 AM

@maguro
Copy link
Author

maguro commented Apr 23, 2019

The plugin is aware of two kinds of strings, ones that are for string values and ones that are for string names, e.g. import paths:

Screen Shot 2019-04-23 at 6 57 47 AM

When a string value is used somewhere a string name is required, the proper error occurs:

Screen Shot 2019-04-23 at 6 58 30 AM

@maguro maguro changed the title Add support for multi-line strings Add support for multiline strings Apr 28, 2019
@kshchepanovskyi
Copy link
Collaborator

This issue is closed as plugin is not supported anymore.
Please switch to https://github.com/jvolkman/intellij-protobuf-editor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants