feat(ws): Add Workspace Data Vol column functionality to workspaces table #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: Generate kubebuilder project Signed-off-by: Jiri Daněk <[email protected]> * fixup add unittests gha Signed-off-by: Jiri Daněk <[email protected]> * fixup disable permissions for all of the available scopes Signed-off-by: Jiri Daněk <[email protected]> * fixup add triggers for release branches Signed-off-by: Jiri Daněk <[email protected]> * fixup remove duplicated gitignores Signed-off-by: Jiri Daněk <[email protected]> * fixup remove workflow dispatch Signed-off-by: Jiri Daněk <[email protected]> * Apply suggestions from code review Co-authored-by: Mathew Wicks <[email protected]> Signed-off-by: Jiri Daněk <[email protected]> * fixup rename the project to workspace-controller Signed-off-by: Jiri Daněk <[email protected]> * fixup update kubebuilder to 3.15 https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v3.15.0 Signed-off-by: Jiri Daněk <[email protected]> --------- Signed-off-by: Jiri Daněk <[email protected]>
* feat(ws): initial commit for backend Signed-off-by: Eder Ignatowicz <[email protected]> * Fixing docker build Signed-off-by: Eder Ignatowicz <[email protected]> * Fixing git ignore Signed-off-by: Eder Ignatowicz <[email protected]> --------- Signed-off-by: Eder Ignatowicz <[email protected]>
* feat (ws): Backend Kubernetes client - Creation of Kubernetes Client; - Wrapping the client on application; Signed-off-by: Eder Ignatowicz <[email protected]> * Update workspaces/backend/cmd/main.go Co-authored-by: Mathew Wicks <[email protected]> * Adding .docker ignore Signed-off-by: Eder Ignatowicz <[email protected]> --------- Signed-off-by: Eder Ignatowicz <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
* feat(ws): add `Workspace` and `WorkspaceKind` CRD scaffolds Co-authored-by: Mathew Wicks <[email protected]> Signed-off-by: Jiri Daněk <[email protected]> * fixup, regenerate WOrkspaceKind to be cluster scope Signed-off-by: Jiri Daněk <[email protected]> * fixes to crd spec Signed-off-by: Mathew Wicks <[email protected]> * updates to CRD spec Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Jiri Daněk <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
…w#16) Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Mathew Wicks <[email protected]>
* feat: client ui frontend scaffolding In this PR: - UI frontend scaffolding - Github Action for frontend and backend Most of the content of this PR is extract from https://github.com/patternfly/patternfly-react-seed/tree/v6. Thank you so much patternfly team for the seed! Signed-off-by: Eder Ignatowicz <[email protected]> * Changes requested by code review Signed-off-by: Eder Ignatowicz <[email protected]> * Fixing icons Signed-off-by: Eder Ignatowicz <[email protected]> --------- Signed-off-by: Eder Ignatowicz <[email protected]>
* feat(ws): add `containerSecurityContext` to WorkspaceKind + cleanup descriptions Signed-off-by: Mathew Wicks <[email protected]> * feat(ws): make all optional fields go pointers Signed-off-by: Mathew Wicks <[email protected]> * feat(ws): remove `readOnlyRootFilesystem=true` from tests Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Mathew Wicks <[email protected]>
…kubeflow#21) Signed-off-by: Mathew Wicks <[email protected]>
…low#22) * feat(ws): implement a reconciliation loop for the workspace Signed-off-by: Adem Baccara <[email protected]> * remove comments Signed-off-by: Adem Baccara <[email protected]> * add correct rbac permission for controller Signed-off-by: Adem Baccara <[email protected]> * implemented collision handling using ownerReferences Signed-off-by: Adem Baccara <[email protected]> * update the status field during workspace reconciliation Signed-off-by: Adem Baccara <[email protected]> * add watcher to workspace kind Signed-off-by: Adem Baccara <[email protected]> * handle the case that multiple ports are specified for an image Signed-off-by: Adem Baccara <[email protected]> * generate correctly the StatefulSet spec Signed-off-by: Adem Baccara <[email protected]> * set status.state of the Workspace Signed-off-by: Adem Baccara <[email protected]> * add rbac permission for configmap Signed-off-by: Adem Baccara <[email protected]> * update dockerfile Signed-off-by: Adem Baccara <[email protected]> * mathew updates Signed-off-by: Mathew Wicks <[email protected]> * mathew updates 2 Signed-off-by: Mathew Wicks <[email protected]> * mathew updates 3 Signed-off-by: Mathew Wicks <[email protected]> * fix todos Signed-off-by: Adem Baccara <[email protected]> * mathew updates 4 Signed-off-by: Mathew Wicks <[email protected]> * handle extraEnv value replacement Signed-off-by: Adem Baccara <[email protected]> * mathew updates 5 Signed-off-by: Mathew Wicks <[email protected]> * mathew updates 6 Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Adem Baccara <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
…script-loader` (kubeflow#24) Signed-off-by: Eder Ignatowicz <[email protected]>
* test(ws): add safety prompt for E2E test execution Signed-off-by: Adem Baccara <[email protected]> * mathew updates 1 Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Adem Baccara <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
* test(ws): add e2e tests Signed-off-by: Adem Baccara <[email protected]> * mathew updates 1 Signed-off-by: Mathew Wicks <[email protected]> * mathew updates 2 Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Adem Baccara <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
* run the kubebuilder e2e test Signed-off-by: Jiri Daněk <[email protected]> * fixup cluster must be named kind Signed-off-by: Jiri Daněk <[email protected]> * fixup, specify kind version Signed-off-by: Jiri Daněk <[email protected]> * mathew commit 1 Signed-off-by: Mathew Wicks <[email protected]> * mathew commit 2 Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Jiri Daněk <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
* feat(ws): populate the status.pauseTime on the workspace Signed-off-by: Adem Baccara <[email protected]> * test(ws): add unit test Signed-off-by: Adem Baccara <[email protected]> * mathew commit 1 Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Adem Baccara <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
…beflow#34) * add validating webhook Signed-off-by: Adem Baccara <[email protected]> * add tests for workspacekind and workspace webhooks Signed-off-by: Adem Baccara <[email protected]> * re-add cert-manager Signed-off-by: Adem Baccara <[email protected]> * refactor ValidateCreate and ValidateUpdate functions in wokrspaceKind webhook Signed-off-by: Adem Baccara <[email protected]> * add e2e test for webhooks Signed-off-by: Adem Baccara <[email protected]> * mathew refactor 1 Signed-off-by: Mathew Wicks <[email protected]> * mathew refactor 2 Signed-off-by: Mathew Wicks <[email protected]> * mathew refactor 3 Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Adem Baccara <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
* feat(ws): use controller-runtime with backend Signed-off-by: Mathew Wicks <[email protected]> * revert healthcheck to normal results Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Mathew Wicks <[email protected]>
Signed-off-by: Eder Ignatowicz <[email protected]>
* feat(ws): Notebooks 2.0 // Backend // List Workspaces API - II In this PR: - FUP for Notebooks 2.0 // Backend // List Workspaces API (kubeflow#60) review - Create /api/v1/workspaces to return all workspaces - Review API endpoints as requested Signed-off-by: Eder Ignatowicz <[email protected]> * Notebooks 2.0 // Backend // CRUD Workspaces API In this PR: - Created handlers and repositories for create, get and delete workspace - Improved the type of our json response Signed-off-by: Eder Ignatowicz <[email protected]> * feat(ws): Notebooks 2.0 // Backend // List WorkspaceKinds This PR builds on top of: kubeflow#61 and kubeflow#65 In this PR: - Created handlers and repositories for get workspacekinds This PR closes kubeflow#51 Signed-off-by: Eder Ignatowicz <[email protected]> * mathew: fix linting Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Eder Ignatowicz <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Griffin-Sullivan <[email protected]>
Signed-off-by: Eder Ignatowicz <[email protected]>
…flow#73) Signed-off-by: Griffin-Sullivan <[email protected]>
* feat(ws): Notebooks 2.0 // Backend // List namespaces kubeflow#53 Signed-off-by: Eder Ignatowicz <[email protected]> * adding test coverage Signed-off-by: Eder Ignatowicz <[email protected]> * ci: run controller and backend tests on pr Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Eder Ignatowicz <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
…ow#137) * chore: update controller kubebuilder Signed-off-by: Mathew Wicks <[email protected]> * chore: add new controller linting Signed-off-by: Mathew Wicks <[email protected]> * chore: update backend (similar to controller kubebuilder update) Signed-off-by: Mathew Wicks <[email protected]> * chore: add new backend linting Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Mathew Wicks <[email protected]>
kubeflow#140) * Workspaces initial frontend Signed-off-by: paulovmr <[email protected]> * Fixing a CVE and cypress test Signed-off-by: Eder Ignatowicz <[email protected]> --------- Signed-off-by: paulovmr <[email protected]> Signed-off-by: Eder Ignatowicz <[email protected]> Co-authored-by: Eder Ignatowicz <[email protected]>
Signed-off-by: paulovmr <[email protected]>
* test(ws): enhance e2e test setup and cleanup Signed-off-by: Adem Baccara <[email protected]> * code review fixes Signed-off-by: Adem Baccara <[email protected]> * remove env variable from e2e test GHA Signed-off-by: Adem Baccara <[email protected]> * lint fixes Signed-off-by: Adem Baccara <[email protected]> * mathew updates 1 Signed-off-by: Mathew Wicks <[email protected]> --------- Signed-off-by: Adem Baccara <[email protected]> Signed-off-by: Mathew Wicks <[email protected]> Co-authored-by: Mathew Wicks <[email protected]>
Signed-off-by: Griffin-Sullivan <[email protected]>
* ci: add semantic PRs action Signed-off-by: Adem Baccara <[email protected]> * ci: add release.yaml Signed-off-by: Adem Baccara <[email protected]> * ci: update semantic pr action to latest version and use scopes instead of disalowScopes Signed-off-by: Adem Baccara <[email protected]> * keep only validate PR title Signed-off-by: Adem Baccara <[email protected]> --------- Signed-off-by: Adem Baccara <[email protected]>
Signed-off-by: Elay Aharoni (EXT-Nokia) <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ElayAharoni
deleted the
RHOAIENG-16563-Notebooks-V2-Workspace-Data-Vol-column
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #149
added popup with the worspace data vol info, that will show when hovering on the data vol column field.
please inform me if anything needs to be changes in matter of functionality or styling.
added a picture of the change: