Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add events for pdb blocking deprovisioning #1849

Open
gaetansnl opened this issue Nov 27, 2024 · 8 comments
Open

add events for pdb blocking deprovisioning #1849

gaetansnl opened this issue Nov 27, 2024 · 8 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. triage/accepted Indicates an issue or PR is ready to be actively worked on. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@gaetansnl
Copy link

Description

What problem are you trying to solve?

Currently nothing tells drifted nodes are blocked by pdb. A feature like #224 but for pdb is very useful

How important is this feature to you?

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@gaetansnl gaetansnl added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 27, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 27, 2024
@jonathan-innis
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 10, 2024
@jonathan-innis
Copy link
Member

/kind good-first-issue

@k8s-ci-robot
Copy link
Contributor

@jonathan-innis: The label(s) kind/good-first-issue cannot be applied, because the repository doesn't have them.

In response to this:

/kind good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jonathan-innis jonathan-innis added the good-first-issue Good for newcomers label Dec 10, 2024
@jonathan-innis
Copy link
Member

Currently nothing tells drifted nodes are blocked by pdb

Can you show the configuration that you are using? As I'm reading it, it looks like we should block so long as the reason that the node is not eligible is that there is a PDB that is blocking so long as you don't have TGP set on your NodeClaim.

@jonathan-innis jonathan-innis removed the good-first-issue Good for newcomers label Dec 10, 2024
@jonathan-innis
Copy link
Member

/triage need-information

@k8s-ci-robot
Copy link
Contributor

@jonathan-innis: The label(s) triage/need-information cannot be applied, because the repository doesn't have them.

In response to this:

/triage need-information

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jonathan-innis
Copy link
Member

/triage needs-information

@k8s-ci-robot k8s-ci-robot added the triage/needs-information Indicates an issue needs more information in order to work on it. label Dec 10, 2024
@github-actions GitHub Actions
Copy link

This issue has been inactive for 14 days. StaleBot will close this stale issue after 14 more days of inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. triage/accepted Indicates an issue or PR is ready to be actively worked on. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gaetansnl @k8s-ci-robot @jonathan-innis