🐛 (go/v4) Fix issue with scaffolding multiple webhooks for the same resource #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
e2e-test-go-v4-conversion
branch
2 times, most recently
from
3b9c7d5 to
a7fab10
Compare
camilamacedo86
changed the title
camilamacedo86
changed the title
camilamacedo86
force-pushed
the
e2e-test-go-v4-conversion
branch
7 times, most recently
from
182dc8f to
03e167c
Compare
Previously, attempting to create multiple webhooks for the same resource with different configurations (e.g., `--defaulting` and `--programmatic-validation`) resulted in an error indicating that the webhook already exists. This update allows multiple webhook types to be scaffolded for a single resource without conflict, providing flexibility for users be able to scaffold different types of webhooks for the same GKV afterwords and without the need to be all by once.
camilamacedo86
force-pushed
the
e2e-test-go-v4-conversion
branch
from
03e167c to
ae3bcf6
Compare
camilamacedo86
commented
Nov 5, 2024
There was a problem hiding this comment.
It is a very small bug so I will move forward
I will not make nobody waste time on the reviews here when we have a lot of open PRs that we really need a hand on the reviews.
Anyway, if someone has any suggestion for improvement and etc please fell free to send a PR against. Your help is very welcome and appreciated !
camilamacedo86
added
the
lgtm
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Nov 9, 2024
We are reverting the changes done in the PR kubernetes-sigs#4286. We are just keeping the e2e tests improvements. We will not able to solve the issue kubernetes-sigs#4146 without add new markers. We cannot skip the action to write an webhook since it will result in incomplete inplementation in the <kind>_webhook.go as in the <kind>_webhook_test.go
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 9, 2024
🐛 revert the changes done in the PR #4286
vtrenton
pushed a commit
to vtrenton/kubebuilder
that referenced
this pull request
Nov 20, 2024
We are reverting the changes done in the PR kubernetes-sigs#4286. We are just keeping the e2e tests improvements. We will not able to solve the issue kubernetes-sigs#4146 without add new markers. We cannot skip the action to write an webhook since it will result in incomplete inplementation in the <kind>_webhook.go as in the <kind>_webhook_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to create multiple webhooks for the same resource with different configurations (e.g.,
--defaultingand--programmatic-validation) resulted in an error indicating that the webhook already exists.This update allows multiple webhook types to be scaffolded for a single resource without conflict. Users can scaffold different webhooks for the same GKV afterwards without needing to do so all at once, as expected.
Either we are adding tests to cover the webhook undergo/v4 conversion type.
The tests are scaffolding the conversion webhook after the defaulting and validation were created already.
Therefore, we are validating the fix done in this PR.
Closes: #4146