feat(ui): Improve the new highlighting system

[Sigmanificient]

Currently, the new highlighter is calibrated to use rust, but it causes issues when rendering Makefile. As you can see comments are highlighted. Moreover, the tool would benefit a lot from a more in-depth colorizing

[Sigmanificient]

Having a color highlighting similar to nvim capabilities would be really nice:

[kyu08]

@Sigmanificient

Thanks for your feed back! 🚀
At first, I agree your opinion. I'll show why the syntax highlighting is poor after v0.50.0.

I had no choice but poor syntax highlighting because if the language other than ml is specified here, when fzf-make is launched in a neovim terminal, unexpected background highlighting happened.

If you know something to fix this, please let me know.

If the language other than ml is specified here

In this case, make is specified.

In a neovim terminal	Not in a neovim terminal

I think this issue need to be solved, so I remain this issue open.

[Sigmanificient]

I also run into the same issue when trying to change the ml extension for mk:

  postPatch = ''
    substituteInPlace src/usecase/tui/ui.rs \
      --replace-fail '("ml")' '("mk")'
  '';

Taking a closer look at syntect library, I come to the conclusion that it uses multiples submodules to register highlighters, listed within the testdata directory I believe the Makefile definition comes from this file. After digging a bit more, it turns out that bat is also using the same library 😮, and better, the same definition to parse the Makefile syntax, along a small patch to improve performance. Their approach is very generic, which makes it hard for me to understand what is happening, as I only have a very small background with rust. From what I see, they seem to load binary files containing a compressed version of the highlighter.

I was a sublime text user a while ago, so I have tinkered with making my own syntax, and I remembered that there was also a file to map matched keywords to their respective colors. I wrote a small language definition for the HRM language, take a look at the hrm.sublime-color-scheme file. Maybe there could be a way to provide a custom one to the library?

[Sigmanificient]

let ss = SyntaxSet::load_defaults_newlines();

let mut ts = ThemeSet::load_defaults();
ts.add_from_folder("./").unwrap();
// dbg!(&ts.themes);

let theme = &mut ts.themes["OneHalfDark"].clone();
let syntax = ss.find_syntax_by_extension("mk").unwrap();

Using this bit of code, I was able to successfully load a OneHalfDark.tmTheme (an equivalent to a .sublime-color-scheme, using XML instead of YAML) I have borrowed for my experiment 😄

I made a branch on my fork in case you would need to test it:
https://github.com/Sigmanificient/fzf-make/tree/proof-of-concept

[kyu08]

I made a branch on my fork in case you would need to test it:
https://github.com/Sigmanificient/fzf-make/tree/proof-of-concept

@Sigmanificient
Wow! Thanks! This looks perfect even within neovim's terminal!

Could you please submit as PR? I'll review it asap.