From 4c65eb81e10a064f1f99022c8a831633e8f09c01 Mon Sep 17 00:00:00 2001
From: superbonaci <superbonaci@aol.com>
Date: Thu, 25 Jul 2024 01:00:45 +0200
Subject: [PATCH] Only escape backslashes, single quotes, and newlines when
 writing ffmetadata (#1161)

* Only escape backslashes and single quotes in SanitizeKeyValue

this documentation is correct:
https://ffmpeg.org/ffmpeg-utils.html

this is outdated:
https://ffmpeg.org/ffmpeg-formats.html#metadata

* Return LINE_FEED to SanitizeKeyValue

* Add comment to SanitizeKeyValue =;# do not need to be escaped
---
 TwitchDownloaderCore/Tools/FfmpegMetadata.cs | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/TwitchDownloaderCore/Tools/FfmpegMetadata.cs b/TwitchDownloaderCore/Tools/FfmpegMetadata.cs
index d5065c3f..12017f75 100644
--- a/TwitchDownloaderCore/Tools/FfmpegMetadata.cs
+++ b/TwitchDownloaderCore/Tools/FfmpegMetadata.cs
@@ -87,6 +87,7 @@ private static async Task SerializeChapters(StreamWriter sw, IEnumerable<VideoMo
             }
         }
 
+        // https://trac.ffmpeg.org/ticket/11096 The Ffmpeg documentation is outdated and =;# do not need to be escaped.
         private static string SanitizeKeyValue(string str)
         {
             if (string.IsNullOrWhiteSpace(str))
@@ -94,16 +95,14 @@ private static string SanitizeKeyValue(string str)
                 return str;
             }
 
-            if (str.AsSpan().IndexOfAny(@$"=;#\{LINE_FEED}") == -1)
+            if (str.AsSpan().IndexOfAny(@$"\'{LINE_FEED}") == -1)
             {
                 return str;
             }
 
             return new StringBuilder(str)
-                .Replace("=", @"\=")
-                .Replace(";", @"\;")
-                .Replace("#", @"\#")
                 .Replace(@"\", @"\\")
+                .Replace("'", @"\'")
                 .Replace(LINE_FEED, $@"\{LINE_FEED}")
                 .ToString();
         }