Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Products Dropdown to Navbar #108

Closed
ankushbhardwaj408 opened this issue Dec 6, 2023 · 12 comments
Closed

Add Products Dropdown to Navbar #108

ankushbhardwaj408 opened this issue Dec 6, 2023 · 12 comments
Assignees
Labels
framework/hugo good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement Improvement in current feature language/css language/html language/javascript Javascript related

Comments

@ankushbhardwaj408
Copy link
Member

Current Behavior

Desired Behavior

Improve navbar with a user-friendly product dropdown menu in the navbar that showcases our products.

Screenshots

Screenshot 2023-12-06 213151

Acceptance Tests

Mockups


Contributor Guide

@ankushbhardwaj408
Copy link
Member Author

@leecalcote I would like to work on that.

@leecalcote
Copy link
Member

Thank you, @ankushbhardwaj408

@ankushbhardwaj408
Copy link
Member Author

i used the svg of cloud native performance(smp-light.svg) from layer5 and its not working.
Screenshot 2023-12-07 100305

@leecalcote
Copy link
Member

Thanks for the progress report. Are you giving up?

@ankushbhardwaj408
Copy link
Member Author

No i am not giving up. I am asking for help👀

@leecalcote leecalcote added help wanted Extra attention is needed good first issue Good for newcomers labels Dec 7, 2023
@Raj100679
Copy link

@leecalcote , Can I know what has to be done here, I would love to work on this?

@Akshun-01
Copy link

Hey @leecalcote, I would like to work on this one, if it's free.

@Akshun-01
Copy link

Hey, this is how it is looking as of now, I am going to make some responsive breakpoints, and some other changes like border glow and hover.(as in the reference)
Do we have any other suggestions regarding this?
image

Also, @ankushbhardwaj408, would you please guide me to the original page you took reference from, I want to check code implementation for consistency throughout the codebase by using a similar coding style.
Thanks!^^

@ankushbhardwaj408
Copy link
Member Author

Hi @Akshun-01 I did not take reference from the code. I used the mockup from #82.

@Akshun-01
Copy link

Akshun-01 commented Dec 11, 2023

Hey @ritiksaxena124 @vishalvivekm , I am almost done with the dropdown component. Actually, I was just about to add breakpoints for responsiveness, but when I was doing that I realized that the homepage is not responsive for starters (I checked the deployed site and on my mobile as well.)
image

I think we should first make the base responsive so that other elements are not that tough to configure.

@Akshun-01
Copy link

localhost_1313.-.Google.Chrome.2023-12-11.22-11-32.mp4

Also, this is the current state of the dropdown, I will be adding responsive breakpoints later.
And if you want anything to be changed or tweaked, please give your feedback. So that I may work on it!

@iArchitSharma
Copy link
Contributor

Just for reference, this issue is now being addressed here: #127
Therefor am closing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework/hugo good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement Improvement in current feature language/css language/html language/javascript Javascript related
Development

No branches or pull requests

5 participants