From 156a017c57f1daa268d6951595c664d0955316a0 Mon Sep 17 00:00:00 2001 From: Saurabh Kumar Date: Fri, 26 Apr 2024 18:01:59 +0530 Subject: [PATCH 1/3] Add space between strings in print --- src/libasr/codegen/asr_to_llvm.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libasr/codegen/asr_to_llvm.cpp b/src/libasr/codegen/asr_to_llvm.cpp index f8b9d7e407..35bbf4c176 100644 --- a/src/libasr/codegen/asr_to_llvm.cpp +++ b/src/libasr/codegen/asr_to_llvm.cpp @@ -7986,7 +7986,7 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor && ASRUtils::is_character(*ASRUtils::expr_type(x.m_values[i - 1])))) { args.push_back(sep); } else { - sep_no_space = sep_no_space != nullptr ? sep_no_space : builder->CreateGlobalStringPtr(""); + sep_no_space = sep_no_space != nullptr ? sep_no_space : builder->CreateGlobalStringPtr(" "); args.push_back(sep_no_space); } } From f91e0c109dae6b548d37aa6c49400bdec7769649 Mon Sep 17 00:00:00 2001 From: Saurabh Kumar Date: Fri, 26 Apr 2024 18:12:34 +0530 Subject: [PATCH 2/3] Fix mistake --- src/libasr/codegen/asr_to_llvm.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/libasr/codegen/asr_to_llvm.cpp b/src/libasr/codegen/asr_to_llvm.cpp index 35bbf4c176..133abc4f94 100644 --- a/src/libasr/codegen/asr_to_llvm.cpp +++ b/src/libasr/codegen/asr_to_llvm.cpp @@ -7981,12 +7981,10 @@ class ASRToLLVMVisitor : public ASR::BaseVisitor for (size_t i=0; iCreateGlobalStringPtr(" "); + sep_no_space = sep_no_space != nullptr ? sep_no_space : builder->CreateGlobalStringPtr(""); args.push_back(sep_no_space); } } From 6fc0b6a8abd23ebbba51d48177341e35ea1dec0c Mon Sep 17 00:00:00 2001 From: Saurabh Kumar Date: Fri, 26 Apr 2024 18:16:59 +0530 Subject: [PATCH 3/3] Tests: Update references --- .../reference/runtime-test_list_item_mixed_print-a3fd49f.json | 2 +- .../runtime-test_list_item_mixed_print-a3fd49f.stdout | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/reference/runtime-test_list_item_mixed_print-a3fd49f.json b/tests/reference/runtime-test_list_item_mixed_print-a3fd49f.json index fde8aee79c..b9c25f807d 100644 --- a/tests/reference/runtime-test_list_item_mixed_print-a3fd49f.json +++ b/tests/reference/runtime-test_list_item_mixed_print-a3fd49f.json @@ -6,7 +6,7 @@ "outfile": null, "outfile_hash": null, "stdout": "runtime-test_list_item_mixed_print-a3fd49f.stdout", - "stdout_hash": "9d9a68fea29f11320efb0764ce38ed3d4090f64457b0f1eb10251a2b", + "stdout_hash": "382a58aa2b426d46c2f22f343df9d99eb41653855b679300aade5102", "stderr": null, "stderr_hash": null, "returncode": 0 diff --git a/tests/reference/runtime-test_list_item_mixed_print-a3fd49f.stdout b/tests/reference/runtime-test_list_item_mixed_print-a3fd49f.stdout index a3f624820b..6e19008748 100644 --- a/tests/reference/runtime-test_list_item_mixed_print-a3fd49f.stdout +++ b/tests/reference/runtime-test_list_item_mixed_print-a3fd49f.stdout @@ -1,5 +1,5 @@ -Hello -This isLPython + Hello +This is LPython 1 2 3 ... 3 4 5 The first element is: 1 The middle element is: 3