Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(php-cs-fixer): separate from code-quality-pack, add new rule sets, change cache path #19

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(php-cs-fixer): separate from code-quality-pack, add new rule sets, change cache path #19

wants to merge 2 commits into from

Conversation

lucasmirloup
Copy link
Member

@lucasmirloup lucasmirloup commented Jul 20, 2023 •
edited
Loading

Closes #14

As of v3.11:

  • Configure phpdoc_separation => groups (new in this version, see PHP-CS-Fixer/PHP-CS-Fixer@a7ed665)
  • add these rule sets : @PhpCsFixer, @PhpCsFixer:risky, @Symfony:risky
  • remove redundant rules configuration
  • move cache file to var/cache/.php-cs-fixer.cache

@lucasmirloup lucasmirloup requested a review from thislg July 20, 2023 10:21
@lucasmirloup lucasmirloup self-assigned this Jul 20, 2023
@lucasmirloup
Copy link
Member Author

lucasmirloup commented Jul 20, 2023 •
edited
Loading

@thislg Y'a plusieurs modifs dans la PR, certaines sont débattables 😉

Je pars du principe que cette recette ne va s'appliquer qu'aux nouveaux projets ou à ceux ayant PHP CS Fixer >= 3.11.

Du coup je pense qu'on peut se permettre d'enfin utiliser PHP CS Fixer à son plein potentiel.
Ex: les rule sets risky (qui ne portent pas très bien leur nom 😄) : en regardant de près y'a rien de vraiment dangereux.
Ils sont séparés des rule sets normaux pour que les gens ne cassent pas les pieds aux devs de la lib dans des cas pourris type "j'ai surchargé les fonctions natives PHP dans mes scripts".

Sur le sujet de la méthode de recette Flex, je ne sais toujours pas si ça serait mieux de garder ce fichier de config dans le code-quality-pack et de déclarer un conflit avec la recette Flex officielle CS-Fixer 🤷.

@lucasmirloup
fix(php-cs-fixer): separate from code-quality-pack, add new rule sets…
78e75e5 
…, change cache path

As of v3.11:
- Configure `phpdoc_separation` => `groups` (new in this version, see PHP-CS-Fixer/PHP-CS-Fixer@a7ed665)
- add these rule sets : `@PhpCsFixer`, `@PhpCsFixer:risky`, `@Symfony:risky`
- remove redundant rules configuration
- move cache file to `var/cache/.php-cs-fixer.cache`
@lucasmirloup lucasmirloup requested a review from thislg July 20, 2023 12:23
@lucasmirloup lucasmirloup marked this pull request as draft August 1, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thislg thislg Awaiting requested review from thislg

At least 1 approving review is required to merge this pull request.

Assignees

@lucasmirloup lucasmirloup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: friendsofphp/php-cs-fixer & code-quality-pack conflict
2 participants
@lucasmirloup @thislg