Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/Lie): a Lie algebra is solvable iff it is solvable after faithfully flat base change #20808

Closed
wants to merge 2 commits into from

Conversation

jcommelin
Copy link
Member


Open in Gitpod

@jcommelin jcommelin requested a review from ocfnash January 17, 2025 13:18
@github-actions github-actions bot added the large-import Automatically added label for PRs with a significant increase in transitive imports label Jan 17, 2025
Copy link

github-actions bot commented Jan 17, 2025

PR summary 57c8589a72

Import changes exceeding 2%

% File
+31.88% Mathlib.Algebra.Lie.Nilpotent
+43.78% Mathlib.Algebra.Lie.Solvable

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Lie.Solvable 1126 1619 +493 (+43.78%)
Mathlib.Algebra.Lie.Nilpotent 1258 1659 +401 (+31.88%)
Import changes for all files
Files Import difference
Mathlib.Algebra.Lie.Weights.RootSystem 328
Mathlib.Algebra.Lie.Weights.Killing 332
Mathlib.Algebra.Lie.Weights.Chain 353
7 files Mathlib.Algebra.Lie.Derivation.Killing Mathlib.Algebra.Lie.Killing Mathlib.Algebra.Lie.LieTheorem Mathlib.Algebra.Lie.TraceForm Mathlib.Algebra.Lie.Weights.Basic Mathlib.Algebra.Lie.Weights.Cartan Mathlib.Algebra.Lie.Weights.Linear
354
Mathlib.Algebra.Lie.CartanExists Mathlib.Algebra.Lie.Rank 357
4 files Mathlib.Algebra.Lie.CartanSubalgebra Mathlib.Algebra.Lie.EngelSubalgebra Mathlib.Algebra.Lie.Engel Mathlib.Algebra.Lie.Nilpotent
401
Mathlib.Algebra.Lie.Character Mathlib.Algebra.Lie.InvariantForm 418
3 files Mathlib.Algebra.Lie.Semisimple.Basic Mathlib.Algebra.Lie.Semisimple.Defs Mathlib.Algebra.Lie.Solvable
493

Declarations diff

+ derivedSeriesOfIdeal_baseChange
+ derivedSeries_baseChange
+ instance {A : Type*} [CommRing A] [Algebra R A] [IsSolvable L] : IsSolvable (A ⊗[R] L) := by
+ isSolvable_tensorProduct_iff
+ one_tmul_eq_zero_iff

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jan 17, 2025
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like where this is heading :)

Thanks!

bors d+

Mathlib/Algebra/Lie/Solvable.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Lie/Solvable.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Lie/Solvable.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 17, 2025

✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@jcommelin
Copy link
Member Author

bors r+

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Jan 17, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jan 17, 2025
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jan 17, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Lie): a Lie algebra is solvable iff it is solvable after faithfully flat base change [Merged by Bors] - feat(Algebra/Lie): a Lie algebra is solvable iff it is solvable after faithfully flat base change Jan 17, 2025
@mathlib-bors mathlib-bors bot closed this Jan 17, 2025
@mathlib-bors mathlib-bors bot deleted the jmc-solvable-basechange branch January 17, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated large-import Automatically added label for PRs with a significant increase in transitive imports ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants