-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Algebra/Lie): a Lie algebra is solvable iff it is solvable after faithfully flat base change #20808
Conversation
jcommelin
commented
Jan 17, 2025
… faithfully flat base change
PR summary 57c8589a72Import changes exceeding 2%
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Algebra.Lie.Solvable | 1126 | 1619 | +493 (+43.78%) |
Mathlib.Algebra.Lie.Nilpotent | 1258 | 1659 | +401 (+31.88%) |
Import changes for all files
Files | Import difference |
---|---|
Mathlib.Algebra.Lie.Weights.RootSystem |
328 |
Mathlib.Algebra.Lie.Weights.Killing |
332 |
Mathlib.Algebra.Lie.Weights.Chain |
353 |
7 filesMathlib.Algebra.Lie.Derivation.Killing Mathlib.Algebra.Lie.Killing Mathlib.Algebra.Lie.LieTheorem Mathlib.Algebra.Lie.TraceForm Mathlib.Algebra.Lie.Weights.Basic Mathlib.Algebra.Lie.Weights.Cartan Mathlib.Algebra.Lie.Weights.Linear |
354 |
Mathlib.Algebra.Lie.CartanExists Mathlib.Algebra.Lie.Rank |
357 |
4 filesMathlib.Algebra.Lie.CartanSubalgebra Mathlib.Algebra.Lie.EngelSubalgebra Mathlib.Algebra.Lie.Engel Mathlib.Algebra.Lie.Nilpotent |
401 |
Mathlib.Algebra.Lie.Character Mathlib.Algebra.Lie.InvariantForm |
418 |
3 filesMathlib.Algebra.Lie.Semisimple.Basic Mathlib.Algebra.Lie.Semisimple.Defs Mathlib.Algebra.Lie.Solvable |
493 |
Declarations diff
+ derivedSeriesOfIdeal_baseChange
+ derivedSeries_baseChange
+ instance {A : Type*} [CommRing A] [Algebra R A] [IsSolvable L] : IsSolvable (A ⊗[R] L) := by
+ isSolvable_tensorProduct_iff
+ one_tmul_eq_zero_iff
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like where this is heading :)
Thanks!
bors d+
✌️ jcommelin can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Oliver Nash <[email protected]>
bors r+ |
… faithfully flat base change (#20808)
Pull request successfully merged into master. Build succeeded: |