Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pokedex-react-native-vanilla] This repo is based on expo and is not vanilla #2

Open
dk0r opened this issue Jun 13, 2017 · 2 comments

Comments

@dk0r
Copy link

dk0r commented Jun 13, 2017

The pokedex-react-native-vanilla repo linked below is not actually 'vanilla' but instead uses expo:
https://github.com/learnapollo/pokedex-react-native-vanilla

Note:

  • This repo is missing android and ios directories
  • This repo has commit descriptions like: "migrated to expo"
  • Doing a yarn start in this repo launches an expo instance
@marktani
Copy link
Collaborator

Can you try with this commit instead: 73f49fe?

@dk0r
Copy link
Author

dk0r commented Jun 15, 2017

[73f49fe] does appear to be vanilla but it has following issues:

  1. When building, the directory name must be shortened else some build errors pop up.
    Solution: Rename the pokedex-react-native-vanilla-73f49fe30f55176ffd6a03fa0eae42e8b215a55a folder to pokedex-react-native-vanilla-73f49fe

  2. Building exercise-01-solution produces this error (note: all the remaining exercise-0[*]-solution's seem to be fine).
    Solution: Modify the index.android.js and index.ios.js files as follows:
    Change AppRegistry.registerComponent('PokedexRNVanilla', () => () => routes) to AppRegistry.registerComponent('PokedexRNVanilla01', () => () => routes)

  3. Doing react-native run-android yields the following deprecation warning but the app still builds successfully:
    (node:15672) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants