Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Configuration of it-length-prefixed MAX_DATA_LENGTH via PeerStreams Options #2880

Open
justin0mcateer opened this issue Dec 6, 2024 · 1 comment
Labels
exp/beginner Can be confidently tackled by newcomers help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@justin0mcateer
Copy link

The PeerStreams class does not configure and does not allow for configuration of the it-length-prefixed 'decode' function. This causes it-length-prefixed to default to 4 MB (4 * 1024 * 1024). Sending messages over this size succeeds without issue. When the receiving side starts to decode the transmitted data, it throws if the encoded length is over 4MB.

  • Version:
    2.3.1

  • Platform:
    Linux master 6.11.6-arch1-1 #1 SMP PREEMPT_DYNAMIC Fri, 01 Nov 2024 03:30:41 +0000 x86_64 GNU/Linux
    Brave Browser 130.1.71.123

  • Subsystem:
    pubsub

Severity:

Medium

Description:

Sending large messages using the PeerStreams class

Steps to reproduce the error:

Send any message over 4 megabytes (4 * 1024 * 1024).
Observe there is no error on the sending side
Observe the receiving side throws an error and does not receive the message.

@justin0mcateer justin0mcateer added the need/triage Needs initial labeling and prioritization label Dec 6, 2024
@achingbrain
Copy link
Member

Makes sense - please can you submit a PR with a test?

@achingbrain achingbrain added kind/enhancement A net-new feature or improvement to an existing feature help wanted Seeking public contribution on this issue exp/beginner Can be confidently tackled by newcomers and removed need/triage Needs initial labeling and prioritization labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/beginner Can be confidently tackled by newcomers help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants