Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-featured identify implementation #358

Open
1 task
ralexstokes opened this issue Nov 21, 2019 · 4 comments
Open
1 task

Full-featured identify implementation #358

ralexstokes opened this issue Nov 21, 2019 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@ralexstokes
Copy link
Contributor

We should reach feature-parity w/ the Go implementation of identify.

Some things missing:

  • Sharing our view of our local addresses
@ShadowJonathan
Copy link
Contributor

What do you mean with that? That we are able to send local multiaddresses to remote peers when in the identify stage, or we send our view of their peer address when in the identify stage?

@ShadowJonathan
Copy link
Contributor

Should just be an easy fix if the client can grab the current connecting peer's multiaddr

@dhuseby dhuseby added the help wanted Extra attention is needed label Oct 3, 2024
@vipulnayyar
Copy link

Hey @pacrob , can you please assign me this issue?

@kt-wawro kt-wawro moved this from In Progress to Done in PLDG Cohort 1 Github Board Dec 18, 2024
@kt-wawro kt-wawro moved this from Done to In Progress in PLDG Cohort 1 Github Board Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants