-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps(if-watch): update if-watch to v3.2.1 #5758
deps(if-watch): update if-watch to v3.2.1 #5758
Conversation
This pull request has merge conflicts. Could you please resolve them @brenodt? 🙏 |
…on deprecation issue on ios
377afdc
to
47679a9
Compare
47679a9
to
a2ac9f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has merge conflicts. Could you please resolve them @brenodt? 🙏 |
caea2bc
to
528723d
Compare
Hi @elenaf9 , thanks for the review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, and thanks for your PR! I don't think we even need a version bump right? As even the end user can update by doing cargo upgrade -p if-watch
and it will update if-watch
to 3.2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Addressed the remaining issues
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
missed this, with this dependabot is not able to merge PR's by itself as it needs the `send-it` label. also add a clause for the dismiss of stale approvals to not do so when the last commit was done by one of the `rust-libp2p` maintainers, so that we don't dismiss approvals if the last commit was a merge of master into the PR that is necessary before merging the PR. Latest example of this happening [here](#5758 (comment)) Pull-Request: #5809.
Description
Bumps the
if-watch
version to 3.2.1, aiming to fix #5628.Since this
if-watch
PR, thesystem-configuration
version has been updated, which enables compiling for iOS targets.Notes & open questions
I'm not sure if I should update the changelogs to include the PR link?
Also, should the main libp2p version be bumped to 0.54.3?
I don't see 0.54.2 in crates, so I wasn't sure, but did it anyway to enable testing locally.
This change made possible compiling for
aarch64-apple-ios-sim
via cargo lipo and using the resulting static lib without XCode complaining about the deprecated interface.Change checklist