Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Support explicit digest in mod list #922

Open
1 task done
qlonik opened this issue Jun 18, 2024 · 6 comments
Open
1 task done

[FEAT] Support explicit digest in mod list #922

qlonik opened this issue Jun 18, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request work-in-progress Stale exempt

Comments

@qlonik
Copy link

qlonik commented Jun 18, 2024

Is this a new feature request?

  • I have searched the existing issues

Name of mod

mod-scripts (general)

Wanted change

Add support for specifying digests in the list of mods, e.g.:

DOCKER_MODS=ghcr.io/linuxserver/mods:universal-calibre-v7.12.0@sha256:e8aad70cc71c65587e28711ab16a0ffa1bbcb707b462a6313b721f7622529be3|ghcr.io/linuxserver/mods:lazylibrarian-ffmpeg@sha256:5083d9f2bdfcb27edf65a55e7c05d0ae8ce309d02d5f0cdc83bfe8e95c942dd4

Reason for change

This provides extra enforcement of the mod version.

I have renovate bot manage these sha256 digests for me: https://github.com/qlonik/musical-parakeet/blob/90396d3c0287656ad87c97e522a6d483f83ccf37/kubernetes/main/apps/default/lazylibrarian/app/helmrelease.yaml#L47-L60, so it is not a very big burden. I suspect other people might not have a setup like this, but it would be helpful to support explicit digests.

Proposed code change

No. It seems that either get_blob_sha needs to change or the call before this function needs to check for presence of sha256 in tag.

@qlonik qlonik added the enhancement New feature or request label Jun 18, 2024
qlonik added a commit to qlonik/musical-parakeet that referenced this issue Jun 18, 2024
@LinuxServer-CI
Copy link

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@TheRedCyclops
Copy link

implementing this or explicit version numbers would be great

@LinuxServer-CI
Copy link

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@asardaes
Copy link

asardaes commented Nov 2, 2024

+1 and hoping this is not closed due to inactivity

@LinuxServer-CI
Copy link

This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

@thespad
Copy link
Member

thespad commented Dec 23, 2024

I'll have a look at this, it may be possible but it's going to require a bunch of changes to how we currently handle mods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request work-in-progress Stale exempt
Projects
Status: Issues
Development

No branches or pull requests

5 participants