-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Support explicit digest in mod list #922
Comments
See linuxserver/docker-mods#922 for a feature request.
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
implementing this or explicit version numbers would be great |
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
+1 and hoping this is not closed due to inactivity |
This issue has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
I'll have a look at this, it may be possible but it's going to require a bunch of changes to how we currently handle mods |
Is this a new feature request?
Name of mod
mod-scripts (general)
Wanted change
Add support for specifying digests in the list of mods, e.g.:
Reason for change
This provides extra enforcement of the mod version.
I have renovate bot manage these sha256 digests for me: https://github.com/qlonik/musical-parakeet/blob/90396d3c0287656ad87c97e522a6d483f83ccf37/kubernetes/main/apps/default/lazylibrarian/app/helmrelease.yaml#L47-L60, so it is not a very big burden. I suspect other people might not have a setup like this, but it would be helpful to support explicit digests.
Proposed code change
No. It seems that either
get_blob_sha
needs to change or the call before this function needs to check for presence of sha256 in tag.The text was updated successfully, but these errors were encountered: