Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Provide separate jellyfin-opencl-intel mods for legacy and non-legacy Intel iGPUs #971

Closed
1 task done
solidsnake1298 opened this issue Oct 30, 2024 · 6 comments
Closed
1 task done
Labels
enhancement New feature or request

Comments

@solidsnake1298
Copy link

Is this a new feature request?

  • I have searched the existing issues

Name of mod

jellyfin-opencl-intel

Wanted change

Intel has dropped OpenCL support for pre-Tigerlake CPUs. Intel compute packages newer than 24.35.30872.22 will no longer support HD/UHD 5XX and 6XX iGPUs.

Specifying a version is an option, but perhaps having a "legacy" opencl mod would be more clean, in addition to stating in the mod's documentation that this is happening.

jellyfin-opencl-intel-legacy or something like that. Which is pinned to 24.35.30872.22.

https://github.com/intel/compute-runtime/blob/master/LEGACY_PLATFORMS.md

Reason for change

Intel dropped support for pre-Tigerlake CPUs for Intel compute packages newer than 24.35.30872.22.

Proposed code change

Create a new docker hub tag for that is pinned to an Intel compute version that supports legacy Intel CPUs.

jellyfin-opencl-intel-legacy is pinned to version 24.35.30872.22.

@solidsnake1298 solidsnake1298 added the enhancement New feature or request label Oct 30, 2024
@aptalca
Copy link
Member

aptalca commented Oct 31, 2024

This mod has versioned releases. Users can pull a version tag that is compatible with their device.

Intel drops support for architectures all the time. What you consider legacy may be different than someone else's legacy. Legacy is a moving target.

@solidsnake1298
Copy link
Author

solidsnake1298 commented Oct 31, 2024

Intel calls them legacy platforms.

I understand that you can specify a version for the mod. I just recommended this to a Jellyfin user in our matrix chat. But most users don't know that. Don't know which version to pin. There's no documentation for the mod specifying what Intel considers legacy and what version they should use for what platform in this mod's documentation.

Adding a "legacy" tagged version, "if your CPU is 10th gen core and older use legacy", just makes it easier for users.

Screenshot_20241030-232650.png

@aptalca
Copy link
Member

aptalca commented Oct 31, 2024

Yes, and when Intel deprecates support for a newer architecture down the line, the version pushed as legacy then will be newer than your legacy device supports. That's what I mean by legacy is a moving target. It contains a list of various architectures, not a single one.

if your CPU is 10th gen core and older

That's a much better solution to list in the readme which gens are supported up to which version.

We do something similar for the various Intel drivers in our ffmpeg image: https://github.com/linuxserver/docker-ffmpeg?tab=readme-ov-file#included-intel-drivers-latest-versions-compiled

PRs welcome

@solidsnake1298
Copy link
Author

#973

@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Nov 3, 2024
@quietsy
Copy link
Member

quietsy commented Dec 27, 2024

@solidsnake1298 Can you please test the following tag linuxserver/mods:pull_request_996 and verify that opencl works on legacy intel cpus?
#996
Has been pushed, you can try the latest build.

@quietsy quietsy reopened this Dec 27, 2024
@LinuxServer-CI LinuxServer-CI moved this from Done to Issues in Issue & PR Tracker Dec 27, 2024
@quietsy quietsy closed this as completed Dec 28, 2024
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Dec 28, 2024
@solidsnake1298
Copy link
Author

@solidsnake1298 Can you please test the following tag linuxserver/mods:pull_request_996 and verify that opencl works on legacy intel cpus? #996 Has been pushed, you can try the latest build.

Unfortunately, I do not have a "legacy" CPU to test with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants