Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cameras Coordinate System #9

Closed
eduardramon opened this issue Dec 6, 2020 · 4 comments
Closed

Cameras Coordinate System #9

eduardramon opened this issue Dec 6, 2020 · 4 comments

Comments

@eduardramon
Copy link

Hi there,

First of all congrats on the project and on the code. It's really neat 🔥 .

I'm trying to run the code with my own scene and, even though the losses are printed with kind of meaningful values, they do not decrease and the learnt scene doesn't resemble at all at what it should. I was wondering if the issue could be related to the coordinate system used.

My coordinate system is this way:

  • Cameras look towards z.
  • Usually, if the object is at the origin, cameras position are somewhere in -z.

Could it be you are assuming an OpenGL-like coordinate system and that it could be the reason it doesn't work?

  • Here cameras look towards -z.
  • Cameras are usually located around +z if the object is at the origin.

Any thoughts will be very welcome.

Thanks in advance!

@eduardramon
Copy link
Author

Just found out the problem was due to the images and masks sorting. Working like a charm 👍 !

@lioryariv
Copy link
Owner

Glad it worked out!

@kajalsanklecha
Copy link

Do we need masks for all the images to run the code?

@lioryariv
Copy link
Owner

Yes.
As I mentioned here - #10 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants